fix(gift): 선물 상세 라벨을 보정한다
This commit is contained in:
@@ -424,7 +424,7 @@ internal fun Context.resolveGiftDetailText(text: GiftDetailText): String = when
|
|||||||
Key.UNDELIVERABLE_LABEL -> R.string.gift_inbox_undeliverable
|
Key.UNDELIVERABLE_LABEL -> R.string.gift_inbox_undeliverable
|
||||||
Key.UNDELIVERABLE_TITLE -> R.string.gift_detail_undeliverable_title
|
Key.UNDELIVERABLE_TITLE -> R.string.gift_detail_undeliverable_title
|
||||||
Key.UNDELIVERABLE_BODY -> R.string.gift_detail_undeliverable_body
|
Key.UNDELIVERABLE_BODY -> R.string.gift_detail_undeliverable_body
|
||||||
Key.CANCELED_LABEL -> R.string.gift_inbox_canceled
|
Key.CANCELED_LABEL -> R.string.gift_detail_canceled_header
|
||||||
Key.CANCELED_TITLE -> R.string.gift_detail_canceled_title
|
Key.CANCELED_TITLE -> R.string.gift_detail_canceled_title
|
||||||
Key.CANCELED_BODY -> R.string.gift_detail_canceled_body
|
Key.CANCELED_BODY -> R.string.gift_detail_canceled_body
|
||||||
Key.DISPOSAL_NON_RETURN_GUIDANCE -> R.string.gift_detail_disposal_guidance
|
Key.DISPOSAL_NON_RETURN_GUIDANCE -> R.string.gift_detail_disposal_guidance
|
||||||
|
|||||||
@@ -15,7 +15,7 @@
|
|||||||
<string name="gift_cancel_success">Your gift request has been canceled.</string>
|
<string name="gift_cancel_success">Your gift request has been canceled.</string>
|
||||||
<string name="gift_tracking_title">Register tracking</string>
|
<string name="gift_tracking_title">Register tracking</string>
|
||||||
<string name="gift_tracking_application_date">Request date</string>
|
<string name="gift_tracking_application_date">Request date</string>
|
||||||
<string name="gift_tracking_destination">Ship to</string>
|
<string name="gift_tracking_destination">Receiving mailbox</string>
|
||||||
<string name="gift_tracking_courier">Courier</string>
|
<string name="gift_tracking_courier">Courier</string>
|
||||||
<string name="gift_tracking_courier_hint">Select a courier</string>
|
<string name="gift_tracking_courier_hint">Select a courier</string>
|
||||||
<string name="gift_tracking_number">Tracking number</string>
|
<string name="gift_tracking_number">Tracking number</string>
|
||||||
@@ -45,7 +45,7 @@
|
|||||||
<string name="gift_detail_creator">Creator</string>
|
<string name="gift_detail_creator">Creator</string>
|
||||||
<string name="gift_detail_application_received">Request received</string>
|
<string name="gift_detail_application_received">Request received</string>
|
||||||
<string name="gift_detail_info">Gift information</string>
|
<string name="gift_detail_info">Gift information</string>
|
||||||
<string name="gift_detail_counterpart">Other member</string>
|
<string name="gift_detail_counterpart">Creator</string>
|
||||||
<string name="gift_detail_application_no">Request number</string>
|
<string name="gift_detail_application_no">Request number</string>
|
||||||
<string name="gift_detail_paid_can">Cans used</string>
|
<string name="gift_detail_paid_can">Cans used</string>
|
||||||
<string name="gift_detail_can_amount">%1$d Cans</string>
|
<string name="gift_detail_can_amount">%1$d Cans</string>
|
||||||
|
|||||||
@@ -15,7 +15,7 @@
|
|||||||
<string name="gift_cancel_success">ギフトの申請がキャンセルされました。</string>
|
<string name="gift_cancel_success">ギフトの申請がキャンセルされました。</string>
|
||||||
<string name="gift_tracking_title">追跡情報の登録</string>
|
<string name="gift_tracking_title">追跡情報の登録</string>
|
||||||
<string name="gift_tracking_application_date">申請日</string>
|
<string name="gift_tracking_application_date">申請日</string>
|
||||||
<string name="gift_tracking_destination">発送先</string>
|
<string name="gift_tracking_destination">受取私書箱</string>
|
||||||
<string name="gift_tracking_courier">配送会社</string>
|
<string name="gift_tracking_courier">配送会社</string>
|
||||||
<string name="gift_tracking_courier_hint">配送会社を選択</string>
|
<string name="gift_tracking_courier_hint">配送会社を選択</string>
|
||||||
<string name="gift_tracking_number">追跡番号</string>
|
<string name="gift_tracking_number">追跡番号</string>
|
||||||
@@ -45,7 +45,7 @@
|
|||||||
<string name="gift_detail_creator">クリエイター</string>
|
<string name="gift_detail_creator">クリエイター</string>
|
||||||
<string name="gift_detail_application_received">申請受付</string>
|
<string name="gift_detail_application_received">申請受付</string>
|
||||||
<string name="gift_detail_info">ギフト情報</string>
|
<string name="gift_detail_info">ギフト情報</string>
|
||||||
<string name="gift_detail_counterpart">相手のニックネーム</string>
|
<string name="gift_detail_counterpart">クリエイター</string>
|
||||||
<string name="gift_detail_application_no">申請番号</string>
|
<string name="gift_detail_application_no">申請番号</string>
|
||||||
<string name="gift_detail_paid_can">使用した缶</string>
|
<string name="gift_detail_paid_can">使用した缶</string>
|
||||||
<string name="gift_detail_can_amount">%1$d缶</string>
|
<string name="gift_detail_can_amount">%1$d缶</string>
|
||||||
|
|||||||
@@ -15,7 +15,7 @@
|
|||||||
<string name="gift_cancel_success">선물 신청이 취소되었습니다.</string>
|
<string name="gift_cancel_success">선물 신청이 취소되었습니다.</string>
|
||||||
<string name="gift_tracking_title">운송장 등록</string>
|
<string name="gift_tracking_title">운송장 등록</string>
|
||||||
<string name="gift_tracking_application_date">신청일</string>
|
<string name="gift_tracking_application_date">신청일</string>
|
||||||
<string name="gift_tracking_destination">보낼 주소</string>
|
<string name="gift_tracking_destination">받는 사서함</string>
|
||||||
<string name="gift_tracking_courier">택배사</string>
|
<string name="gift_tracking_courier">택배사</string>
|
||||||
<string name="gift_tracking_courier_hint">택배사 선택</string>
|
<string name="gift_tracking_courier_hint">택배사 선택</string>
|
||||||
<string name="gift_tracking_number">운송장 번호</string>
|
<string name="gift_tracking_number">운송장 번호</string>
|
||||||
@@ -45,7 +45,7 @@
|
|||||||
<string name="gift_detail_creator">크리에이터</string>
|
<string name="gift_detail_creator">크리에이터</string>
|
||||||
<string name="gift_detail_application_received">신청 접수</string>
|
<string name="gift_detail_application_received">신청 접수</string>
|
||||||
<string name="gift_detail_info">선물 정보</string>
|
<string name="gift_detail_info">선물 정보</string>
|
||||||
<string name="gift_detail_counterpart">상대 닉네임</string>
|
<string name="gift_detail_counterpart">크리에이터</string>
|
||||||
<string name="gift_detail_application_no">신청번호</string>
|
<string name="gift_detail_application_no">신청번호</string>
|
||||||
<string name="gift_detail_paid_can">사용한 캔</string>
|
<string name="gift_detail_paid_can">사용한 캔</string>
|
||||||
<string name="gift_detail_can_amount">%1$d캔</string>
|
<string name="gift_detail_can_amount">%1$d캔</string>
|
||||||
|
|||||||
@@ -273,12 +273,19 @@ class GiftDetailViewModelTest {
|
|||||||
setLocale(Locale.KOREAN)
|
setLocale(Locale.KOREAN)
|
||||||
}
|
}
|
||||||
)
|
)
|
||||||
listOf(Locale.KOREAN, Locale.ENGLISH, Locale.JAPANESE).forEach { locale ->
|
mapOf(
|
||||||
|
Locale.KOREAN to Triple("크리에이터", "취소 완료", "받는 사서함"),
|
||||||
|
Locale.ENGLISH to Triple("Creator", "Cancellation complete", "Receiving mailbox"),
|
||||||
|
Locale.JAPANESE to Triple("クリエイター", "キャンセル完了", "受取私書箱")
|
||||||
|
).forEach { (locale, expected) ->
|
||||||
val localized = context.createConfigurationContext(
|
val localized = context.createConfigurationContext(
|
||||||
Configuration(context.resources.configuration).apply {
|
Configuration(context.resources.configuration).apply {
|
||||||
setLocale(locale)
|
setLocale(locale)
|
||||||
}
|
}
|
||||||
)
|
)
|
||||||
|
assertEquals(expected.first, localized.getString(R.string.gift_detail_counterpart))
|
||||||
|
assertEquals(expected.second, localized.resolveGiftDetailText(GiftDetailText.Key.CANCELED_LABEL))
|
||||||
|
assertEquals(expected.third, localized.getString(R.string.gift_tracking_destination))
|
||||||
GiftDetailText.Key.entries.forEach { key ->
|
GiftDetailText.Key.entries.forEach { key ->
|
||||||
val text = localized.resolveGiftDetailText(key)
|
val text = localized.resolveGiftDetailText(key)
|
||||||
assertTrue(text.isNotBlank())
|
assertTrue(text.isNotBlank())
|
||||||
|
|||||||
Reference in New Issue
Block a user