refactor(content): 콘텐츠 접근 가드를 공통화한다
This commit is contained in:
+5
-5
@@ -13,7 +13,7 @@ class ContentMainFragmentLoginGuardSourceTest {
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/content/ContentMainFragment.kt"
|
||||
).readText()
|
||||
|
||||
assertTrue(source.contains("import kr.co.vividnext.sodalive.v2.main.ensureMainV2NavigationAllowed"))
|
||||
assertTrue(source.contains("import kr.co.vividnext.sodalive.v2.access.ensureV2Access"))
|
||||
assertGuardedStartActivity(source, "private fun onBannerClick(item: ContentBannerUiModel)")
|
||||
assertGuardedStartActivity(source, "audioContentId: Long,\n requiresAdultContentAccess: Boolean = false")
|
||||
assertGuardedStartActivity(source, "seriesId: Long,\n requiresAdultContentAccess: Boolean = false")
|
||||
@@ -40,7 +40,7 @@ class ContentMainFragmentLoginGuardSourceTest {
|
||||
assertTrue(source.contains("openAudioContentDetail(item.audioContentId, item.showAdultBadge)"))
|
||||
assertTrue(source.contains("openAudioContentDetail(audioContentId, findAllTabAudioAdultAccess(audioContentId))"))
|
||||
assertTrue(source.contains("openSeriesDetail(seriesId, findAllTabSeriesAdultAccess(seriesId))"))
|
||||
assertTrue(source.contains("requiresAdultContentAccess = requiresAdultContentAccess"))
|
||||
assertTrue(source.contains("AccessRequirement.forAdultContent(requiresAdultContentAccess)"))
|
||||
assertFalse(source.contains("ContentCommentedAudioUiModel.showAdultBadge"))
|
||||
assertFalse(source.contains("ContentOriginalSeriesUiModel.showAdultBadge"))
|
||||
}
|
||||
@@ -48,14 +48,14 @@ class ContentMainFragmentLoginGuardSourceTest {
|
||||
private fun assertGuardedStartActivity(source: String, functionSignature: String) {
|
||||
val functionSource = source.substringFrom(functionSignature)
|
||||
assertTrue(
|
||||
"$functionSignature must call ensureMainV2NavigationAllowed before startActivity.",
|
||||
functionSource.indexOf("ensureMainV2NavigationAllowed") in 0 until functionSource.indexOf("startActivity")
|
||||
"$functionSignature must call ensureV2Access before startActivity.",
|
||||
functionSource.indexOf("ensureV2Access") in 0 until functionSource.indexOf("startActivity")
|
||||
)
|
||||
}
|
||||
|
||||
private fun assertBeforeGuard(source: String, expectedReturn: String) {
|
||||
val returnIndex = source.indexOf(expectedReturn)
|
||||
val guardIndex = source.indexOf("ensureMainV2NavigationAllowed", returnIndex)
|
||||
val guardIndex = source.indexOf("ensureV2Access", returnIndex)
|
||||
|
||||
assertTrue("Missing source: $expectedReturn", returnIndex >= 0)
|
||||
assertTrue("$expectedReturn must stay before guard.", guardIndex > returnIndex)
|
||||
|
||||
+3
-3
@@ -392,7 +392,7 @@ class ContentMainFragmentSourceTest {
|
||||
|
||||
assertSourceContains(source, "import kr.co.vividnext.sodalive.v2.main.MainV2Activity")
|
||||
assertSourceContains(source, "private fun openContentAllTab(type: MainContentAllType, sort: ContentSort)")
|
||||
assertSourceContains(source, "ensureMainV2NavigationAllowed")
|
||||
assertSourceContains(source, "ensureV2Access")
|
||||
assertSourceContains(source, "(activity as? MainV2Activity)?.openContentAllTab(type, sort)")
|
||||
assertSourceContains(source, "binding.viewContentOriginalSeriesTitle.ivSectionTitleChevron.setOnClickListener")
|
||||
assertSourceContains(source, "openContentAllTab(MainContentAllType.ORIGINAL, ContentSort.LATEST)")
|
||||
@@ -407,10 +407,10 @@ class ContentMainFragmentSourceTest {
|
||||
assertTrue(source.contains("viewContentNewAndHotTitle.ivSectionTitleChevron.setOnClickListener"))
|
||||
assertTrue(source.contains("openContentOverview(ContentOverviewType.NEW_AND_HOT_AUDIO)"))
|
||||
val functionSource = source.substringFrom("private fun openContentOverview(type: ContentOverviewType)")
|
||||
assertTrue(functionSource.contains("ensureMainV2NavigationAllowed"))
|
||||
assertTrue(functionSource.contains("ensureV2Access"))
|
||||
assertTrue(functionSource.contains("startActivity(ContentOverviewActivity.newIntent(requireContext(), type))"))
|
||||
assertTrue(
|
||||
functionSource.indexOf("ensureMainV2NavigationAllowed") <
|
||||
functionSource.indexOf("ensureV2Access") <
|
||||
functionSource.indexOf("startActivity(")
|
||||
)
|
||||
}
|
||||
|
||||
+1
-1
@@ -15,7 +15,7 @@ class ContentMainTitleBarActionSourceTest {
|
||||
assertTrue(source.contains("viewContentTitleBar.ivTitleBarCash.setOnClickListener"))
|
||||
assertTrue(source.contains("viewContentTitleBar.ivTitleBarSearch.setOnClickListener"))
|
||||
assertTrue(source.contains("viewContentTitleBar.ivTitleBarStorage.setOnClickListener"))
|
||||
assertTrue(source.contains("ensureMainV2NavigationAllowed"))
|
||||
assertTrue(source.contains("ensureV2Access"))
|
||||
assertTrue(source.contains("CanChargeActivity::class.java"))
|
||||
assertTrue(source.contains("SearchActivity::class.java"))
|
||||
assertTrue(source.contains("AudioContentBoxActivity::class.java"))
|
||||
|
||||
Reference in New Issue
Block a user