refactor(dm): legacy realtime 구현을 제거한다

This commit is contained in:
2026-07-11 22:02:29 +09:00
parent 5ca07ef049
commit 46c3a02655
4 changed files with 27 additions and 431 deletions
@@ -1,174 +0,0 @@
package kr.co.vividnext.sodalive.v2.main.chat.dm
import com.google.gson.Gson
import kr.co.vividnext.sodalive.v2.main.chat.dm.data.DmChatEventClient
import kr.co.vividnext.sodalive.v2.main.chat.dm.data.DmChatMessageResponse
import okhttp3.MediaType.Companion.toMediaType
import okhttp3.OkHttpClient
import okhttp3.Protocol
import okhttp3.Response
import okhttp3.ResponseBody.Companion.toResponseBody
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNotNull
import org.junit.Assert.assertTrue
import org.junit.Test
import java.util.concurrent.CountDownLatch
import java.util.concurrent.TimeUnit
class DmChatEventClientTest {
@Test
fun `비정상 HTTP 응답은 failure callback으로 전달된다`() {
val failureLatch = CountDownLatch(1)
var failure: Throwable? = null
val client = clientWithResponse(
code = 500,
body = "server error"
)
client.connect(
token = "test-token",
roomId = 10L,
listener = object : TestListener() {
override fun onFailure(throwable: Throwable) {
failure = throwable
failureLatch.countDown()
}
}
)
failureLatch.await(2, TimeUnit.SECONDS)
assertNotNull(failure)
assertEquals("Unexpected code 500", failure?.message)
}
@Test
fun `trailing blank line 없이 종료된 마지막 frame도 message callback으로 전달된다`() {
val messageLatch = CountDownLatch(1)
var receivedMessage: DmChatMessageResponse? = null
val client = clientWithResponse(
code = 200,
body = "event: message\ndata: ${messageJson()}"
)
client.connect(
token = "test-token",
roomId = 10L,
listener = object : TestListener() {
override fun onMessage(message: DmChatMessageResponse) {
receivedMessage = message
messageLatch.countDown()
}
}
)
messageLatch.await(2, TimeUnit.SECONDS)
assertEquals(10L, receivedMessage?.messageId)
assertEquals("안녕하세요", receivedMessage?.textMessage)
}
@Test
fun `취소되지 않은 SSE stream이 EOF로 종료되면 failure callback으로 전달된다`() {
val failureLatch = CountDownLatch(1)
var failure: Throwable? = null
val client = clientWithResponse(
code = 200,
body = "event: connected\n\n"
)
client.connect(
token = "test-token",
roomId = 10L,
listener = object : TestListener() {
override fun onFailure(throwable: Throwable) {
failure = throwable
failureLatch.countDown()
}
}
)
failureLatch.await(2, TimeUnit.SECONDS)
assertNotNull(failure)
assertEquals("SSE stream closed", failure?.message)
}
@Test
fun `SSE 전용 client는 공유 client의 read timeout을 제거한다`() {
val requestLatch = CountDownLatch(1)
var requestReadTimeoutMillis: Int? = null
val baseClient = OkHttpClient.Builder()
.readTimeout(60, TimeUnit.SECONDS)
.addInterceptor { chain ->
requestReadTimeoutMillis = chain.readTimeoutMillis()
requestLatch.countDown()
Response.Builder()
.request(chain.request())
.protocol(Protocol.HTTP_1_1)
.code(200)
.message("test")
.body("event: connected\n\n".toResponseBody("text/event-stream".toMediaType()))
.build()
}
.build()
val client = DmChatEventClient(
okHttpClient = baseClient,
gson = Gson(),
baseUrl = "https://example.com"
)
client.connect(
token = "test-token",
roomId = 10L,
listener = TestListener()
)
assertTrue(requestLatch.await(2, TimeUnit.SECONDS))
assertEquals(60_000, baseClient.readTimeoutMillis)
assertEquals(0, requestReadTimeoutMillis)
}
private fun clientWithResponse(
code: Int,
body: String
): DmChatEventClient {
val okHttpClient = OkHttpClient.Builder()
.addInterceptor { chain ->
Response.Builder()
.request(chain.request())
.protocol(Protocol.HTTP_1_1)
.code(code)
.message("test")
.body(body.toResponseBody("text/event-stream".toMediaType()))
.build()
}
.build()
return DmChatEventClient(
okHttpClient = okHttpClient,
gson = Gson(),
baseUrl = "https://example.com"
)
}
private open class TestListener : DmChatEventClient.Listener {
override fun onConnected() = Unit
override fun onMessage(message: DmChatMessageResponse) = Unit
override fun onFailure(throwable: Throwable) = Unit
}
private fun messageJson(): String =
"""
{
"messageId": 10,
"messageType": "TEXT",
"mine": false,
"createdAt": 1000,
"textMessage": "안녕하세요",
"voiceMessageUrl": null,
"senderId": 20,
"senderNickname": "크리에이터",
"senderProfileImageUrl": "https://example.com/profile.png"
}
""".trimIndent().replace("\n", "")
}
@@ -1,83 +0,0 @@
package kr.co.vividnext.sodalive.v2.main.chat.dm
import com.google.gson.Gson
import kr.co.vividnext.sodalive.v2.main.chat.dm.data.DmChatEventParser
import kr.co.vividnext.sodalive.v2.main.chat.dm.data.DmChatMessageResponse
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNull
import org.junit.Test
class DmChatEventParserTest {
private val parser = DmChatEventParser(Gson())
@Test
fun `connected 이벤트는 연결 이벤트로 파싱된다`() {
val event = parser.parse("event: connected\ndata: {}\n\n")
assertEquals(DmChatEventParser.Event.Connected, event)
}
@Test
fun `message 이벤트는 DM 메시지로 파싱된다`() {
val event = parser.parse("event: message\ndata: ${messageJson()}\n\n")
val message = requireMessage(event)
assertEquals(10L, message.messageId)
assertEquals("안녕하세요", message.textMessage)
}
@Test
fun `여러 줄 data는 하나의 message payload로 합쳐 파싱된다`() {
val json = messageJson(textMessage = "첫줄\\n둘째줄")
val splitIndex = json.indexOf("\\\\n") + 2
val event = parser.parse(
"event: message\n" +
"data: ${json.substring(0, splitIndex)}\n" +
"data: ${json.substring(splitIndex)}\n\n"
)
val message = requireMessage(event)
assertEquals("첫줄\n둘째줄", message.textMessage)
}
@Test
fun `data field는 콜론 뒤 공백 하나만 제거한다`() {
val json = messageJson(textMessage = " 앞 공백 유지")
val event = parser.parse("event: message\ndata: $json\n\n")
val message = requireMessage(event)
assertEquals(" 앞 공백 유지", message.textMessage)
}
@Test
fun `잘못된 JSON message 이벤트는 null로 무시된다`() {
val event = parser.parse("event: message\ndata: {not-json}\n\n")
assertNull(event)
}
private fun requireMessage(event: DmChatEventParser.Event?): DmChatMessageResponse {
val messageEvent = event as? DmChatEventParser.Event.Message
requireNotNull(messageEvent)
return messageEvent.message
}
private fun messageJson(
messageId: Long = 10L,
textMessage: String = "안녕하세요"
): String =
"""
{
"messageId": $messageId,
"messageType": "TEXT",
"mine": false,
"createdAt": 1000,
"textMessage": "$textMessage",
"voiceMessageUrl": null,
"senderId": 20,
"senderNickname": "크리에이터",
"senderProfileImageUrl": "https://example.com/profile.png"
}
""".trimIndent().replace("\n", "")
}
@@ -14,7 +14,8 @@ class DmChatRemovedEndpointSourceTest {
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/chat/dm/DmChatRoomViewModel.kt",
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/chat/dm/data/DmChatApi.kt",
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/chat/dm/data/DmChatRepository.kt",
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/chat/dm/data/DmChatSocketClient.kt"
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/chat/dm/data/DmChatSocketClient.kt",
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/chat/dm/data/DmChatSocketModels.kt"
)
activeSources.forEach { path ->
@@ -24,6 +25,9 @@ class DmChatRemovedEndpointSourceTest {
assertFalse("$path must not use removed text REST endpoint", source.contains("messages/text"))
assertFalse("$path must not use SSE accept header", source.contains("text/event-stream"))
assertFalse("$path must not use EventSource", source.contains("EventSource"))
assertFalse("$path must not use STOMP CONNECT frame", source.contains("CONNECT\n"))
assertFalse("$path must not use STOMP SUBSCRIBE frame", source.contains("SUBSCRIBE"))
assertFalse("$path must not use SockJS", source.contains("SockJS"))
}
}
@@ -37,7 +41,7 @@ class DmChatRemovedEndpointSourceTest {
).readText()
assertTrue(viewModel.contains("repository.sendSocketText("))
assertTrue(viewModel.contains("repository.sendLeaveRoom(roomId)"))
assertTrue(viewModel.contains("repository.sendLeaveRoom(roomId = roomId"))
assertTrue(viewModel.contains("repository.closeSocket()"))
assertTrue(repository.contains("fun sendSocketText"))
assertTrue(repository.contains("fun sendLeaveRoom"))
@@ -45,7 +49,7 @@ class DmChatRemovedEndpointSourceTest {
}
@Test
fun `음성 메시지는 전송 API 추가 없이 DTO 필드 보존 범위로 유지한다`() {
fun `음성 메시지는 multipart API 계약만 보존하고 UI에는 연결하지 않는다`() {
val api = projectFile(
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/chat/dm/data/DmChatApi.kt"
).readText()
@@ -57,9 +61,26 @@ class DmChatRemovedEndpointSourceTest {
).readText()
assertTrue(models.contains("@SerializedName(\"voiceMessageUrl\") val voiceMessageUrl: String?"))
assertFalse(api.contains("messages/voice"))
assertFalse(api.contains("Multipart"))
assertFalse(repository.contains("sendDmVoiceMessage"))
assertTrue(api.contains("messages/voice"))
assertTrue(api.contains("Multipart"))
assertTrue(api.contains("voiceMessageFile"))
assertTrue(repository.contains("fun sendVoiceMessage"))
val activity = projectFile(
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/chat/dm/DmChatRoomActivity.kt"
).readText()
assertFalse(activity.contains("sendVoiceMessage"))
assertFalse(activity.contains("voiceMessageFile"))
}
@Test
fun `legacy realtime DmChatEventClient production 파일은 제거되어 있다`() {
assertFalse(
projectFileExists("app/src/main/java/kr/co/vividnext/sodalive/v2/main/chat/dm/data/DmChatEventClient.kt")
)
}
private fun projectFileExists(relativePath: String): Boolean {
return listOf(File(relativePath), File("../$relativePath")).any { it.exists() }
}
private fun projectFile(relativePath: String): File {