From 51bd12fab93fd749c562d649bebe71f7e130d150 Mon Sep 17 00:00:00 2001 From: klaus Date: Fri, 2 Oct 2026 18:31:29 +0900 Subject: [PATCH] =?UTF-8?q?feat(gift):=20=EC=9A=B4=EC=86=A1=EC=9E=A5=20?= =?UTF-8?q?=EB=93=B1=EB=A1=9D=20=EC=83=81=ED=83=9C=EB=A5=BC=20=EC=B6=94?= =?UTF-8?q?=EA=B0=80=ED=95=9C=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../sodalive/v2/gift/GiftTrackingViewModel.kt | 119 +++++++ .../v2/gift/GiftTrackingViewModelTest.kt | 317 ++++++++++++++++++ 2 files changed, 436 insertions(+) create mode 100644 app/src/main/java/kr/co/vividnext/sodalive/v2/gift/GiftTrackingViewModel.kt create mode 100644 app/src/test/java/kr/co/vividnext/sodalive/v2/gift/GiftTrackingViewModelTest.kt diff --git a/app/src/main/java/kr/co/vividnext/sodalive/v2/gift/GiftTrackingViewModel.kt b/app/src/main/java/kr/co/vividnext/sodalive/v2/gift/GiftTrackingViewModel.kt new file mode 100644 index 00000000..bbb1e1c2 --- /dev/null +++ b/app/src/main/java/kr/co/vividnext/sodalive/v2/gift/GiftTrackingViewModel.kt @@ -0,0 +1,119 @@ +package kr.co.vividnext.sodalive.v2.gift + +import androidx.lifecycle.LiveData +import androidx.lifecycle.MutableLiveData +import io.reactivex.rxjava3.android.schedulers.AndroidSchedulers +import io.reactivex.rxjava3.schedulers.Schedulers +import kr.co.vividnext.sodalive.R +import kr.co.vividnext.sodalive.base.BaseViewModel +import kr.co.vividnext.sodalive.common.SharedPreferenceManager +import kr.co.vividnext.sodalive.common.ToastMessage +import kr.co.vividnext.sodalive.v2.gift.data.GiftDetailResponse +import kr.co.vividnext.sodalive.v2.gift.data.GiftRepository + +sealed interface GiftTrackingUiState { + data object Loading : GiftTrackingUiState + data class Content(val detail: GiftTrackingUiModel) : GiftTrackingUiState + data class Error(val message: String?) : GiftTrackingUiState +} + +class GiftTrackingViewModel(private val repository: GiftRepository) : BaseViewModel() { + private val mutableState = MutableLiveData() + val state: LiveData = mutableState + private val mutableSubmitting = MutableLiveData(false) + val isSubmitting: LiveData = mutableSubmitting + private val mutableToast = MutableLiveData() + val toastLiveData: LiveData = mutableToast + private val mutableIneligible = MutableLiveData(false) + val ineligibleLiveData: LiveData = mutableIneligible + private val mutableSubmitSuccess = MutableLiveData(false) + val submitSuccessLiveData: LiveData = mutableSubmitSuccess + private var applicationNo: String? = null + var loadedDetail: GiftDetailResponse? = null + private set + + fun loadInitial(applicationNo: String) { + if (this.applicationNo != null) return + this.applicationNo = applicationNo + if (applicationNo.isBlank()) { + mutableIneligible.value = true + return + } + load(applicationNo) + } + + fun retry() { + if (mutableState.value !is GiftTrackingUiState.Error) return + val number = applicationNo ?: return + load(number) + } + + fun submitTracking(courier: String?, trackingNumber: String) { + val detail = (mutableState.value as? GiftTrackingUiState.Content)?.detail ?: return + if (!detail.isEligible || mutableSubmitting.value == true) return + if (courier == null || !GiftTrackingPresenter.isSubmitEnabled(courier, trackingNumber)) return + val number = applicationNo ?: return + mutableSubmitting.value = true + compositeDisposable.add( + repository.registerGiftTracking(number, GiftTrackingPresenter.toRequest(courier, trackingNumber), authToken()) + .subscribeOn(Schedulers.io()) + .observeOn(AndroidSchedulers.mainThread()) + .subscribe({ response -> + mutableSubmitting.value = false + if (response.success && response.data != null) { + mutableSubmitSuccess.value = true + } else { + showToast(response.message) + } + }, { + mutableSubmitting.value = false + showToast(null) + }) + ) + } + + fun consumeToast(): ToastMessage? = mutableToast.value.also { mutableToast.value = null } + + fun consumeIneligibleEvent(): Boolean { + if (mutableIneligible.value != true) return false + mutableIneligible.value = false + return true + } + + fun consumeSubmitSuccessEvent(): Boolean { + if (mutableSubmitSuccess.value != true) return false + mutableSubmitSuccess.value = false + return true + } + + private fun load(number: String) { + loadedDetail = null + mutableState.value = GiftTrackingUiState.Loading + compositeDisposable.add( + repository.getGiftDetail(number, authToken()) + .subscribeOn(Schedulers.io()) + .observeOn(AndroidSchedulers.mainThread()) + .subscribe({ response -> + val detail = response.data + if (response.success && detail != null) { + val model = GiftTrackingPresenter.present(detail) + loadedDetail = detail.takeIf { model.isEligible } + mutableState.value = GiftTrackingUiState.Content(model) + if (!model.isEligible) mutableIneligible.value = true + } else { + mutableState.value = GiftTrackingUiState.Error(response.message) + } + }, { mutableState.value = GiftTrackingUiState.Error(null) }) + ) + } + + private fun showToast(message: String?) { + mutableToast.value = if (message.isNullOrBlank()) { + ToastMessage(resId = R.string.common_error_unknown) + } else { + ToastMessage(message = message) + } + } + + private fun authToken(): String = "Bearer ${SharedPreferenceManager.token}" +} diff --git a/app/src/test/java/kr/co/vividnext/sodalive/v2/gift/GiftTrackingViewModelTest.kt b/app/src/test/java/kr/co/vividnext/sodalive/v2/gift/GiftTrackingViewModelTest.kt new file mode 100644 index 00000000..618a6be4 --- /dev/null +++ b/app/src/test/java/kr/co/vividnext/sodalive/v2/gift/GiftTrackingViewModelTest.kt @@ -0,0 +1,317 @@ +package kr.co.vividnext.sodalive.v2.gift + +import android.app.Application +import androidx.test.core.app.ApplicationProvider +import io.reactivex.rxjava3.android.plugins.RxAndroidPlugins +import io.reactivex.rxjava3.core.Single +import io.reactivex.rxjava3.plugins.RxJavaPlugins +import io.reactivex.rxjava3.schedulers.Schedulers +import io.reactivex.rxjava3.subjects.SingleSubject +import kr.co.vividnext.sodalive.R +import kr.co.vividnext.sodalive.common.ApiResponse +import kr.co.vividnext.sodalive.common.SharedPreferenceManager +import kr.co.vividnext.sodalive.common.ToastMessage +import kr.co.vividnext.sodalive.v2.gift.data.GiftAddressResponse +import kr.co.vividnext.sodalive.v2.gift.data.GiftApi +import kr.co.vividnext.sodalive.v2.gift.data.GiftDeliveryResponse +import kr.co.vividnext.sodalive.v2.gift.data.GiftDetailInfoResponse +import kr.co.vividnext.sodalive.v2.gift.data.GiftDetailResponse +import kr.co.vividnext.sodalive.v2.gift.data.GiftRepository +import kr.co.vividnext.sodalive.v2.gift.data.GiftTrackingRequest +import kr.co.vividnext.sodalive.v2.gift.data.GiftTrackingResponse +import org.junit.After +import org.junit.Assert.assertEquals +import org.junit.Assert.assertFalse +import org.junit.Assert.assertNull +import org.junit.Assert.assertSame +import org.junit.Assert.assertTrue +import org.junit.Before +import org.junit.Test +import org.junit.runner.RunWith +import org.robolectric.RobolectricTestRunner +import org.robolectric.annotation.Config + +@RunWith(RobolectricTestRunner::class) +@Config(sdk = [28], application = Application::class) +class GiftTrackingViewModelTest { + private lateinit var api: TrackingFakeApi + private lateinit var viewModel: GiftTrackingViewModel + + @Before + fun setUp() { + RxJavaPlugins.setIoSchedulerHandler { Schedulers.trampoline() } + RxAndroidPlugins.setInitMainThreadSchedulerHandler { Schedulers.trampoline() } + RxAndroidPlugins.setMainThreadSchedulerHandler { Schedulers.trampoline() } + SharedPreferenceManager.resetForTest() + SharedPreferenceManager.init(ApplicationProvider.getApplicationContext()) + SharedPreferenceManager.token = "test-token" + api = TrackingFakeApi() + viewModel = GiftTrackingViewModel(GiftRepository(api)) + } + + @After + fun tearDown() { + viewModel.compositeDisposable.clear() + RxJavaPlugins.reset() + RxAndroidPlugins.reset() + SharedPreferenceManager.resetForTest() + } + + @Test + fun `최초 조회만 번호와 인증을 전달하고 로딩 및 콘텐츠에서 중복 조회하지 않는다`() { + assertNull(viewModel.loadedDetail) + viewModel.submitTracking("한진택배", "0123456789") + viewModel.loadInitial("test-gift") + viewModel.loadInitial("other-gift") + viewModel.retry() + assertEquals(GiftTrackingUiState.Loading, viewModel.state.value) + assertNull(viewModel.loadedDetail) + viewModel.submitTracking("한진택배", "0123456789") + val original = detail() + api.detailResponse.onSuccess(ApiResponse(true, original, null)) + assertSame(original, viewModel.loadedDetail) + assertEquals(GiftTrackingUiState.Content(GiftTrackingPresenter.present(detail())), viewModel.state.value) + viewModel.loadInitial("test-gift") + viewModel.retry() + assertEquals(listOf("test-gift" to "Bearer test-token"), api.detailRequests) + assertTrue(api.trackingRequests.isEmpty()) + assertFalse(viewModel.consumeIneligibleEvent()) + } + + @Test + fun `등록 불필요와 사서함 누락과 받은 신청은 종료 이벤트를 한 번만 내고 제출하지 않는다`() { + listOf(detail().copy(trackingRequired = false), detail().copy(mailbox = null), detail().copy(direction = "RECEIVED")) + .forEach { detail -> + val model = GiftTrackingViewModel(GiftRepository(api)) + api.detailResponse = SingleSubject.create() + model.loadInitial("test-gift") + api.detailResponse.onSuccess(ApiResponse(true, detail, null)) + assertNull(model.loadedDetail) + assertEquals(true, model.ineligibleLiveData.value) + assertTrue(model.consumeIneligibleEvent()) + assertFalse(model.consumeIneligibleEvent()) + assertEquals(false, model.ineligibleLiveData.value) + model.submitTracking("한진택배", "0123456789") + model.loadInitial("test-gift") + model.retry() + assertFalse(model.consumeIneligibleEvent()) + model.compositeDisposable.clear() + } + assertEquals(3, api.detailRequests.size) + assertTrue(api.trackingRequests.isEmpty()) + } + + @Test + fun `공백 신청번호는 조회와 제출 없이 등록 불가 이벤트를 한 번만 보낸다`() { + viewModel.loadInitial(" \n ") + viewModel.retry() + viewModel.submitTracking("한진택배", "0123456789") + assertTrue(viewModel.consumeIneligibleEvent()) + assertFalse(viewModel.consumeIneligibleEvent()) + assertTrue(api.detailRequests.isEmpty()) + assertTrue(api.trackingRequests.isEmpty()) + } + + @Test + fun `택배사나 번호가 비어 있으면 제출하지 않는다`() { + loadEligible() + listOf(null to "0123456789", "" to "0123456789", " \t" to "0123456789", "한진택배" to "", "한진택배" to " \n ") + .forEach { (courier, number) -> viewModel.submitTracking(courier, number) } + assertTrue(api.trackingRequests.isEmpty()) + assertEquals(false, viewModel.isSubmitting.value) + assertFalse(viewModel.consumeSubmitSuccessEvent()) + } + + @Test + fun `유효하지 않은 모든 번호는 POST를 호출하지 않는다`() { + loadEligible() + listOf( + "", + "1", + "123456789", + "123456789012345", + " 0123456789", + "0123456789 ", + "01234 56789", + "01234-56789", + "012345678a", + "1234567890", + "١٢٣٤٥٦٧٨٩٠", + " \t\n" + ) + .forEach { number -> + viewModel.submitTracking("한진택배", number) + assertEquals(number, 0, api.trackingRequests.size) + assertEquals(false, viewModel.isSubmitting.value) + assertFalse(viewModel.consumeSubmitSuccessEvent()) + } + } + + @Test + fun `10자리와 14자리 번호는 선행 0을 보존해 제출한다`() { + loadEligible() + listOf("0123456789", "00123456789012").forEach { number -> + api.trackingResponse = SingleSubject.create() + viewModel.submitTracking("한진택배", number) + assertEquals(number, api.trackingRequests.last().second.trackingNumber) + api.trackingResponse.onSuccess(ApiResponse(true, tracking(), null)) + assertTrue(viewModel.consumeSubmitSuccessEvent()) + } + assertEquals(2, api.trackingRequests.size) + } + + @Test + fun `제출 중 재탭은 한글 표시명과 번호 원문으로 한 번만 요청한다`() { + loadEligible() + viewModel.submitTracking("GS25 편의점택배", "00123456789012") + viewModel.submitTracking("한진택배", "9999999999") + viewModel.retry() + assertEquals(true, viewModel.isSubmitting.value) + assertEquals( + listOf( + Triple( + "test-gift", + GiftTrackingRequest("GS25 편의점택배", "00123456789012"), + "Bearer test-token" + ) + ), + api.trackingRequests + ) + assertEquals(1, api.detailRequests.size) + assertFalse(viewModel.consumeSubmitSuccessEvent()) + api.trackingResponse.onSuccess(ApiResponse(true, tracking(), null)) + assertEquals(false, viewModel.isSubmitting.value) + assertEquals(true, viewModel.submitSuccessLiveData.value) + assertTrue(viewModel.consumeSubmitSuccessEvent()) + assertFalse(viewModel.consumeSubmitSuccessEvent()) + assertEquals(false, viewModel.submitSuccessLiveData.value) + } + + @Test + fun `실패 Toast는 한 번만 소비하고 이후 새 실패는 다시 소비한다`() { + loadEligible() + listOf("첫 등록 실패", "다음 등록 실패").forEach { message -> + api.trackingResponse = SingleSubject.create() + viewModel.submitTracking("한진택배", "0123456789") + api.trackingResponse.onSuccess(ApiResponse(false, null, message)) + assertEquals(ToastMessage(message = message), viewModel.consumeToast()) + assertNull(viewModel.consumeToast()) + assertNull(viewModel.toastLiveData.value) + } + } + + @Test + fun `실패 응답은 입력 재전달로 재시도하며 상세 오류나 성공 이벤트를 만들지 않는다`() = + assertSubmitFailure(ApiResponse(false, tracking(), "등록 실패"), ToastMessage(message = "등록 실패")) + + @Test + fun `성공 응답의 데이터가 없으면 공통 오류로 알리고 재시도할 수 있다`() = + assertSubmitFailure(ApiResponse(true, null, " \t"), ToastMessage(resId = R.string.common_error_unknown)) + + @Test + fun `전송 오류는 내부 내용을 숨기고 제출 상태를 해제하여 같은 입력으로 재시도한다`() = + assertSubmitFailure(null, ToastMessage(resId = R.string.common_error_unknown)) + + @Test + fun `상세 실패 응답은 제출 오류와 분리하고 조회만 재시도한다`() = assertDetailFailure(ApiResponse(false, detail(), "조회 실패"), "조회 실패") + + @Test + fun `상세 데이터 누락은 조회 오류로 처리한다`() = assertDetailFailure(ApiResponse(true, null, null), null) + + @Test + fun `상세 전송 오류는 내부 내용을 노출하지 않고 조회만 재시도한다`() = assertDetailFailure(null, null) + + @Test + fun `해제된 제출 요청은 늦은 성공 이벤트를 내지 않는다`() { + loadEligible() + viewModel.submitTracking("한진택배", "0123456789") + viewModel.compositeDisposable.clear() + assertFalse(api.trackingResponse.hasObservers()) + api.trackingResponse.onSuccess(ApiResponse(true, tracking(), null)) + assertFalse(viewModel.consumeSubmitSuccessEvent()) + } + + private fun assertSubmitFailure(response: ApiResponse?, toast: ToastMessage) { + loadEligible() + val content = viewModel.state.value + val courier = "한진택배" + val number = "0012345678" + viewModel.submitTracking(courier, number) + if (response != null) { + api.trackingResponse.onSuccess(response) + } else { + api.trackingResponse.onError(IllegalStateException("private transport detail")) + } + assertEquals(false, viewModel.isSubmitting.value) + assertEquals(toast, viewModel.toastLiveData.value) + assertFalse(viewModel.consumeSubmitSuccessEvent()) + assertEquals(content, viewModel.state.value) + viewModel.retry() + assertEquals(1, api.detailRequests.size) + api.trackingResponse = SingleSubject.create() + viewModel.submitTracking(courier, number) + assertEquals(true, viewModel.isSubmitting.value) + assertEquals(2, api.trackingRequests.size) + assertEquals(api.trackingRequests.first(), api.trackingRequests.last()) + api.trackingResponse.onSuccess(ApiResponse(true, tracking(), null)) + assertEquals(false, viewModel.isSubmitting.value) + assertTrue(viewModel.consumeSubmitSuccessEvent()) + assertFalse(viewModel.consumeSubmitSuccessEvent()) + } + + private fun assertDetailFailure(response: ApiResponse?, message: String?) { + viewModel.loadInitial("test-gift") + if (response != null) { + api.detailResponse.onSuccess(response) + } else { + api.detailResponse.onError(IllegalStateException("private transport detail")) + } + assertEquals(GiftTrackingUiState.Error(message), viewModel.state.value) + assertNull(viewModel.loadedDetail) + assertEquals(false, viewModel.isSubmitting.value) + assertNull(viewModel.toastLiveData.value) + assertFalse(viewModel.consumeIneligibleEvent()) + viewModel.submitTracking("한진택배", "0123456789") + assertTrue(api.trackingRequests.isEmpty()) + api.detailResponse = SingleSubject.create() + viewModel.retry() + assertEquals(GiftTrackingUiState.Loading, viewModel.state.value) + assertNull(viewModel.loadedDetail) + api.detailResponse.onSuccess(ApiResponse(true, detail(), null)) + assertEquals(GiftTrackingUiState.Content(GiftTrackingPresenter.present(detail())), viewModel.state.value) + assertEquals(List(2) { "test-gift" to "Bearer test-token" }, api.detailRequests) + } + private fun loadEligible() { + viewModel.loadInitial("test-gift") + api.detailResponse.onSuccess(ApiResponse(true, detail(), null)) + } + private fun detail() = GiftDetailResponse( + "test-gift", "SENT", "RECEIVED", "접수 완료", + GiftDetailInfoResponse("가상 크리에이터", null, "소형", "도서", "test-gift", 100, null, null), + null, null, GiftAddressResponse("가상 사서함", "000-0000-0000", "가상 주소"), + true, false, null, GiftDeliveryResponse(null, null, null), emptyList() + ) + private fun tracking() = GiftTrackingResponse( + "test-gift", + "TRACKING_REGISTERED", + "등록", + "한진택배", + "0012-34", + "2026-10-02T00:00:00Z", + "2026-10-09T00:00:00Z" + ) + private class TrackingFakeApi : GiftApi by InboxFakeApi() { + val detailRequests = mutableListOf>() + val trackingRequests = mutableListOf>() + var detailResponse = SingleSubject.create>() + var trackingResponse = SingleSubject.create>() + override fun getGiftDetail(applicationNo: String, authHeader: String): Single> = + detailResponse.also { detailRequests.add(applicationNo to authHeader) } + override fun registerGiftTracking( + applicationNo: String, + request: GiftTrackingRequest, + authHeader: String + ): Single> = + trackingResponse.also { trackingRequests.add(Triple(applicationNo, request, authHeader)) } + } +}