refactor(home): 추천 활동 타입을 공용 타입으로 교체한다

This commit is contained in:
2026-06-13 16:21:46 +09:00
parent 55b4d9bc8d
commit 80e8213f12
5 changed files with 29 additions and 45 deletions

View File

@@ -1,17 +1,17 @@
package kr.co.vividnext.sodalive.v2.main.home
import kr.co.vividnext.sodalive.R
import kr.co.vividnext.sodalive.v2.main.home.model.toRecommendedActivityTypeLabelRes
import kr.co.vividnext.sodalive.v2.main.home.model.toCreatorActivityTypeLabelRes
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNull
import org.junit.Test
class RecommendedActivityTypeTest {
class HomeCreatorActivityTypeLabelResTest {
@Test
fun `LIVE maps to live label`() {
assertEquals(
R.string.home_recommendation_activity_live,
"LIVE".toRecommendedActivityTypeLabelRes()
"LIVE".toCreatorActivityTypeLabelRes()
)
}
@@ -19,7 +19,7 @@ class RecommendedActivityTypeTest {
fun `LIVE_REPLAY maps to live label`() {
assertEquals(
R.string.home_recommendation_activity_live,
"LIVE_REPLAY".toRecommendedActivityTypeLabelRes()
"LIVE_REPLAY".toCreatorActivityTypeLabelRes()
)
}
@@ -27,7 +27,7 @@ class RecommendedActivityTypeTest {
fun `AUDIO maps to audio label`() {
assertEquals(
R.string.home_recommendation_activity_audio,
"AUDIO".toRecommendedActivityTypeLabelRes()
"AUDIO".toCreatorActivityTypeLabelRes()
)
}
@@ -35,7 +35,7 @@ class RecommendedActivityTypeTest {
fun `COMMUNITY maps to community label`() {
assertEquals(
R.string.home_recommendation_activity_community,
"COMMUNITY".toRecommendedActivityTypeLabelRes()
"COMMUNITY".toCreatorActivityTypeLabelRes()
)
}
@@ -43,7 +43,7 @@ class RecommendedActivityTypeTest {
fun `lowercase activity type maps to matching label`() {
assertEquals(
R.string.home_recommendation_activity_live,
"live".toRecommendedActivityTypeLabelRes()
"live".toCreatorActivityTypeLabelRes()
)
}
@@ -51,12 +51,12 @@ class RecommendedActivityTypeTest {
fun `mixed case activity type maps to matching label`() {
assertEquals(
R.string.home_recommendation_activity_live,
"Live_RePlay".toRecommendedActivityTypeLabelRes()
"Live_RePlay".toCreatorActivityTypeLabelRes()
)
}
@Test
fun `unknown activity type maps to null`() {
assertNull("UNKNOWN".toRecommendedActivityTypeLabelRes())
assertNull("UNKNOWN".toCreatorActivityTypeLabelRes())
}
}

View File

@@ -50,7 +50,7 @@ import kr.co.vividnext.sodalive.v2.main.home.model.HomeRecommendationPopularComm
import kr.co.vividnext.sodalive.v2.main.home.model.HomeRecommendationPaidStatus
import kr.co.vividnext.sodalive.v2.main.home.model.HomeRecommendationRecentlyActiveCreatorRoute
import kr.co.vividnext.sodalive.v2.main.home.model.HomeRecommendationRecentlyActiveCreatorUiModel
import kr.co.vividnext.sodalive.v2.main.home.model.RecommendedActivityType
import kr.co.vividnext.sodalive.v2.common.CreatorActivityType
import kr.co.vividnext.sodalive.v2.main.home.model.toHomeRecommendationBannerIntent
import kr.co.vividnext.sodalive.v2.main.home.model.toHomeRecommendationBannerRoute
import kr.co.vividnext.sodalive.v2.main.home.model.toHomeRecommendationRecentlyActiveCreatorIntent
@@ -1035,17 +1035,17 @@ class HomeMainFragmentLayoutTest {
fun `home recent activity route maps activity type to target destination`() {
assertEquals(
HomeRecommendationRecentlyActiveCreatorRoute.AudioContent(11L),
recentActivityCreator(RecommendedActivityType.LiveReplay, targetId = 11L)
recentActivityCreator(CreatorActivityType.LiveReplay, targetId = 11L)
.toHomeRecommendationRecentlyActiveCreatorRoute()
)
assertEquals(
HomeRecommendationRecentlyActiveCreatorRoute.AudioContent(12L),
recentActivityCreator(RecommendedActivityType.Audio, targetId = 12L)
recentActivityCreator(CreatorActivityType.Audio, targetId = 12L)
.toHomeRecommendationRecentlyActiveCreatorRoute()
)
assertEquals(
HomeRecommendationRecentlyActiveCreatorRoute.Community(13L),
recentActivityCreator(RecommendedActivityType.Community, targetId = 13L)
recentActivityCreator(CreatorActivityType.Community, targetId = 13L)
.toHomeRecommendationRecentlyActiveCreatorRoute()
)
}
@@ -1054,7 +1054,7 @@ class HomeMainFragmentLayoutTest {
fun `home recent activity route ignores live unknown and missing target`() {
assertEquals(
null,
recentActivityCreator(RecommendedActivityType.Live, targetId = 10L)
recentActivityCreator(CreatorActivityType.Live, targetId = 10L)
.toHomeRecommendationRecentlyActiveCreatorRoute()
)
assertEquals(
@@ -1063,12 +1063,12 @@ class HomeMainFragmentLayoutTest {
)
assertEquals(
null,
recentActivityCreator(RecommendedActivityType.Audio, targetId = null)
recentActivityCreator(CreatorActivityType.Audio, targetId = null)
.toHomeRecommendationRecentlyActiveCreatorRoute()
)
assertEquals(
null,
recentActivityCreator(RecommendedActivityType.Community, targetId = 0L)
recentActivityCreator(CreatorActivityType.Community, targetId = 0L)
.toHomeRecommendationRecentlyActiveCreatorRoute()
)
}
@@ -1406,7 +1406,7 @@ class HomeMainFragmentLayoutTest {
val projectRoot = java.io.File("..").canonicalFile
return java.io.File(
projectRoot,
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/HomeMainFragment.kt"
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/home/HomeMainFragment.kt"
).readText()
}
@@ -1517,7 +1517,7 @@ class HomeMainFragmentLayoutTest {
}
private fun recentActivityCreator(
activityType: RecommendedActivityType?,
activityType: CreatorActivityType?,
targetId: Long?
): HomeRecommendationRecentlyActiveCreatorUiModel {
return HomeRecommendationRecentlyActiveCreatorUiModel(