feat(chat): DM 채팅 실시간 수신을 연결한다
This commit is contained in:
@@ -10,6 +10,7 @@ import io.reactivex.rxjava3.core.Scheduler
|
||||
import io.reactivex.rxjava3.core.Single
|
||||
import io.reactivex.rxjava3.plugins.RxJavaPlugins
|
||||
import io.reactivex.rxjava3.schedulers.Schedulers
|
||||
import io.reactivex.rxjava3.schedulers.TestScheduler
|
||||
import io.reactivex.rxjava3.subjects.SingleSubject
|
||||
import kr.co.vividnext.sodalive.common.ApiResponse
|
||||
import kr.co.vividnext.sodalive.common.SharedPreferenceManager
|
||||
@@ -18,6 +19,8 @@ import kr.co.vividnext.sodalive.v2.main.chat.dm.data.CreateDmChatRoomResponse
|
||||
import kr.co.vividnext.sodalive.v2.main.chat.dm.data.DmChatApi
|
||||
import kr.co.vividnext.sodalive.v2.main.chat.dm.data.DmChatMessageResponse
|
||||
import kr.co.vividnext.sodalive.v2.main.chat.dm.data.DmChatMessagesPageResponse
|
||||
import kr.co.vividnext.sodalive.v2.main.chat.dm.data.DmChatEventClient
|
||||
import kr.co.vividnext.sodalive.v2.main.chat.dm.data.DmChatRealtimeClient
|
||||
import kr.co.vividnext.sodalive.v2.main.chat.dm.data.DmChatRepository
|
||||
import kr.co.vividnext.sodalive.v2.main.chat.dm.data.DmChatRoomOpenResponse
|
||||
import kr.co.vividnext.sodalive.v2.main.chat.dm.data.SendDmChatMessageResponse
|
||||
@@ -32,6 +35,7 @@ import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import org.robolectric.RobolectricTestRunner
|
||||
import org.robolectric.annotation.Config
|
||||
import java.util.concurrent.TimeUnit
|
||||
|
||||
@RunWith(RobolectricTestRunner::class)
|
||||
@Config(sdk = [28], application = Application::class)
|
||||
@@ -39,6 +43,8 @@ class DmChatRoomViewModelTest {
|
||||
|
||||
private val context: Context = ApplicationProvider.getApplicationContext()
|
||||
private lateinit var api: FakeDmChatApi
|
||||
private lateinit var realtimeClient: FakeDmChatRealtimeClient
|
||||
private lateinit var reconnectScheduler: TestScheduler
|
||||
private lateinit var viewModel: DmChatRoomViewModel
|
||||
|
||||
@Before
|
||||
@@ -48,7 +54,13 @@ class DmChatRoomViewModelTest {
|
||||
SharedPreferenceManager.init(context)
|
||||
SharedPreferenceManager.token = "test-token"
|
||||
api = FakeDmChatApi()
|
||||
viewModel = DmChatRoomViewModel(repository = DmChatRepository(api))
|
||||
realtimeClient = FakeDmChatRealtimeClient()
|
||||
reconnectScheduler = TestScheduler()
|
||||
viewModel = DmChatRoomViewModel(
|
||||
repository = DmChatRepository(api, realtimeClient),
|
||||
reconnectScheduler = reconnectScheduler,
|
||||
tokenProvider = { "test-token" }
|
||||
)
|
||||
}
|
||||
|
||||
@After
|
||||
@@ -278,6 +290,254 @@ class DmChatRoomViewModelTest {
|
||||
assertEquals(listOf("기존"), state.messages.map { it.textMessage })
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `roomId가 없으면 realtime 연결과 disconnect를 요청하지 않는다`() {
|
||||
viewModel.connectRealtime()
|
||||
viewModel.disconnectRealtime()
|
||||
|
||||
assertTrue(realtimeClient.connectCalls.isEmpty())
|
||||
assertEquals(0, realtimeClient.cancelCalls)
|
||||
assertTrue(api.disconnectCalls.isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `roomId가 있으면 realtime 연결 후 connected callback에서 최신 메시지를 동기화한다`() {
|
||||
api.enqueueOpenSuccess(
|
||||
openResponse(
|
||||
roomId = 10L,
|
||||
messages = listOf(message(messageId = 1L, textMessage = "기존"))
|
||||
)
|
||||
)
|
||||
api.enqueueMessagesSuccess(
|
||||
messagesPage(
|
||||
messages = listOf(message(messageId = 2L, createdAt = 200L, textMessage = "동기화"))
|
||||
)
|
||||
)
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
|
||||
viewModel.connectRealtime()
|
||||
realtimeClient.listener?.onConnected()
|
||||
|
||||
assertEquals(listOf(RealtimeConnectCall("test-token", 10L)), realtimeClient.connectCalls)
|
||||
assertEquals(listOf(MessagesCall("Bearer test-token", 10L, null, 20)), api.messagesCalls)
|
||||
val state = viewModel.chatRoomStateLiveData.requireValue() as DmChatRoomUiState.Content
|
||||
assertEquals(listOf(1L, 2L), state.messages.map { it.messageId })
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `realtime 연결 중 중복 connect 요청은 무시한다`() {
|
||||
api.enqueueOpenSuccess(openResponse(roomId = 10L))
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
|
||||
viewModel.connectRealtime()
|
||||
viewModel.connectRealtime()
|
||||
|
||||
assertEquals(listOf(RealtimeConnectCall("test-token", 10L)), realtimeClient.connectCalls)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `openRoom 완료 시 realtime 연결 가능 이벤트를 한 번 발행한다`() {
|
||||
api.enqueueOpenSuccess(openResponse(roomId = 10L))
|
||||
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
|
||||
assertTrue(viewModel.roomOpenedEventLiveData.requireValue()?.consume() == true)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `openRoom 완료 이벤트는 observer가 재등록되어도 한 번만 소비된다`() {
|
||||
api.enqueueOpenSuccess(openResponse(roomId = 10L))
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
|
||||
val event = viewModel.roomOpenedEventLiveData.requireValue()
|
||||
|
||||
assertTrue(event?.consume() == true)
|
||||
assertTrue(event?.consume() == null)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `disconnect 진행 중 빠른 reconnect 시 crash 없이 connect를 허용한다`() {
|
||||
val pendingDisconnect = SingleSubject.create<ApiResponse<Boolean>>()
|
||||
api.enqueueOpenSuccess(openResponse(roomId = 10L))
|
||||
api.enqueueDisconnect(pendingDisconnect)
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
|
||||
viewModel.connectRealtime()
|
||||
viewModel.disconnectRealtime()
|
||||
viewModel.connectRealtime()
|
||||
|
||||
assertEquals(2, realtimeClient.connectCalls.size)
|
||||
assertEquals(1, realtimeClient.cancelCalls)
|
||||
assertEquals(listOf(DisconnectCall("Bearer test-token", 10L)), api.disconnectCalls)
|
||||
|
||||
pendingDisconnect.onSuccess(ApiResponse(success = true, data = true))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `realtime message callback은 SSE 메시지를 화면 상태에 병합한다`() {
|
||||
api.enqueueOpenSuccess(openResponse(roomId = 10L))
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
|
||||
viewModel.connectRealtime()
|
||||
realtimeClient.listener?.onMessage(message(messageId = 3L, textMessage = "실시간"))
|
||||
|
||||
val state = viewModel.chatRoomStateLiveData.requireValue() as DmChatRoomUiState.Content
|
||||
assertEquals(listOf(3L), state.messages.map { it.messageId })
|
||||
assertEquals(listOf("실시간"), state.messages.map { it.textMessage })
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `realtime listener callback은 main thread scheduler로 상태를 갱신한다`() {
|
||||
val source = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/chat/dm/DmChatRoomViewModel.kt"
|
||||
).readText()
|
||||
|
||||
assertTrue(source.contains("scheduleRealtimeCallback"))
|
||||
assertTrue(source.contains("AndroidSchedulers.mainThread().scheduleDirect"))
|
||||
assertTrue(source.contains("scheduleRealtimeCallback { syncLatestMessagesAfterReconnect(token = token) }"))
|
||||
assertTrue(source.contains("scheduleRealtimeCallback { onRealtimeMessage(message) }"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `SSE 실패는 3초 뒤 재연결을 예약하고 connected 후 최신 메시지를 동기화한다`() {
|
||||
api.enqueueOpenSuccess(openResponse(roomId = 10L, messages = listOf(message(messageId = 1L, textMessage = "기존"))))
|
||||
api.enqueueMessagesSuccess(
|
||||
messagesPage(messages = listOf(message(messageId = 2L, createdAt = 200L, textMessage = "재연결")))
|
||||
)
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
viewModel.connectRealtime()
|
||||
|
||||
realtimeClient.listener?.onFailure(IllegalStateException("network"))
|
||||
reconnectScheduler.advanceTimeBy(2999L, TimeUnit.MILLISECONDS)
|
||||
|
||||
assertEquals(1, realtimeClient.connectCalls.size)
|
||||
|
||||
reconnectScheduler.advanceTimeBy(1L, TimeUnit.MILLISECONDS)
|
||||
assertEquals(2, realtimeClient.connectCalls.size)
|
||||
assertEquals(RealtimeConnectCall("test-token", 10L), realtimeClient.connectCalls[1])
|
||||
|
||||
realtimeClient.listener?.onConnected()
|
||||
assertEquals(listOf(MessagesCall("Bearer test-token", 10L, null, 20)), api.messagesCalls)
|
||||
val state = viewModel.chatRoomStateLiveData.requireValue() as DmChatRoomUiState.Content
|
||||
assertEquals(listOf(1L, 2L), state.messages.map { it.messageId })
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `SSE 실패 후 예약된 재연결은 main thread callback 경로에서 실행된다`() {
|
||||
val source = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/chat/dm/DmChatRoomViewModel.kt"
|
||||
).readText()
|
||||
val compactSource = source.filterNot { it.isWhitespace() }
|
||||
|
||||
assertTrue(compactSource.contains("scheduleRealtimeCallback{if(shouldReconnectRealtime)connectRealtime(token=token)}"))
|
||||
assertTrue(!compactSource.contains("scheduleDirect({connectRealtime(token=token)}"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `반복 SSE 실패는 foreground 상태에서 3초 기본 간격으로 재연결을 유지한다`() {
|
||||
api.enqueueOpenSuccess(openResponse(roomId = 10L))
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
viewModel.connectRealtime()
|
||||
|
||||
realtimeClient.listener?.onFailure(IllegalStateException("network-1"))
|
||||
reconnectScheduler.advanceTimeBy(3L, TimeUnit.SECONDS)
|
||||
realtimeClient.listener?.onFailure(IllegalStateException("network-2"))
|
||||
reconnectScheduler.advanceTimeBy(2999L, TimeUnit.MILLISECONDS)
|
||||
|
||||
assertEquals(2, realtimeClient.connectCalls.size)
|
||||
|
||||
reconnectScheduler.advanceTimeBy(1L, TimeUnit.MILLISECONDS)
|
||||
|
||||
assertEquals(3, realtimeClient.connectCalls.size)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `disconnect는 예약된 SSE 재연결을 취소한다`() {
|
||||
api.enqueueOpenSuccess(openResponse(roomId = 10L))
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
viewModel.connectRealtime()
|
||||
|
||||
realtimeClient.listener?.onFailure(IllegalStateException("network"))
|
||||
viewModel.disconnectRealtime()
|
||||
reconnectScheduler.advanceTimeBy(3L, TimeUnit.SECONDS)
|
||||
|
||||
assertEquals(1, realtimeClient.connectCalls.size)
|
||||
assertEquals(1, realtimeClient.cancelCalls)
|
||||
assertEquals(listOf(DisconnectCall("Bearer test-token", 10L)), api.disconnectCalls)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `예약 재연결 실행 후 main callback 전 disconnect되면 새 SSE 연결을 만들지 않는다`() {
|
||||
api.enqueueOpenSuccess(openResponse(roomId = 10L))
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
viewModel.connectRealtime()
|
||||
|
||||
realtimeClient.listener?.onFailure(IllegalStateException("network"))
|
||||
viewModel.disconnectRealtime()
|
||||
reconnectScheduler.advanceTimeBy(3L, TimeUnit.SECONDS)
|
||||
|
||||
assertEquals(listOf(RealtimeConnectCall("test-token", 10L)), realtimeClient.connectCalls)
|
||||
assertEquals(1, realtimeClient.cancelCalls)
|
||||
assertEquals(listOf(DisconnectCall("Bearer test-token", 10L)), api.disconnectCalls)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `realtime disconnect 중 중복 요청은 무시하고 완료 후 다시 요청할 수 있다`() {
|
||||
val pendingDisconnect = SingleSubject.create<ApiResponse<Boolean>>()
|
||||
api.enqueueOpenSuccess(openResponse(roomId = 10L))
|
||||
api.enqueueDisconnect(pendingDisconnect)
|
||||
api.enqueueDisconnectSuccess()
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
|
||||
viewModel.disconnectRealtime()
|
||||
viewModel.disconnectRealtime()
|
||||
|
||||
assertEquals(2, realtimeClient.cancelCalls)
|
||||
assertEquals(listOf(DisconnectCall("Bearer test-token", 10L)), api.disconnectCalls)
|
||||
|
||||
pendingDisconnect.onSuccess(ApiResponse(success = true, data = true))
|
||||
viewModel.disconnectRealtime()
|
||||
|
||||
assertEquals(3, realtimeClient.cancelCalls)
|
||||
assertEquals(2, api.disconnectCalls.size)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `disconnect API 진행 중 다시 background로 가면 새 SSE 연결도 cancel하고 API 중복 호출은 하지 않는다`() {
|
||||
val pendingDisconnect = SingleSubject.create<ApiResponse<Boolean>>()
|
||||
api.enqueueOpenSuccess(openResponse(roomId = 10L))
|
||||
api.enqueueDisconnect(pendingDisconnect)
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
|
||||
viewModel.connectRealtime()
|
||||
viewModel.disconnectRealtime()
|
||||
viewModel.connectRealtime()
|
||||
viewModel.disconnectRealtime()
|
||||
|
||||
assertEquals(2, realtimeClient.cancelCalls)
|
||||
assertEquals(listOf(DisconnectCall("Bearer test-token", 10L)), api.disconnectCalls)
|
||||
|
||||
pendingDisconnect.onSuccess(ApiResponse(success = true, data = true))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `realtime disconnect 실패는 채팅 상태를 Error로 바꾸지 않는다`() {
|
||||
api.enqueueOpenSuccess(openResponse(roomId = 10L, messages = listOf(message(messageId = 1L, textMessage = "기존"))))
|
||||
api.enqueueDisconnect(Single.error(IllegalStateException("network")))
|
||||
viewModel.enter(roomId = 10L, creatorId = 0L)
|
||||
|
||||
viewModel.disconnectRealtime()
|
||||
|
||||
val state = viewModel.chatRoomStateLiveData.requireValue() as DmChatRoomUiState.Content
|
||||
assertEquals(listOf(1L), state.messages.map { it.messageId })
|
||||
}
|
||||
|
||||
private fun projectFile(relativePath: String): java.io.File {
|
||||
val candidates = listOf(java.io.File(relativePath), java.io.File("../$relativePath"))
|
||||
return candidates.firstOrNull { it.exists() }
|
||||
?: error("Project file not found: $relativePath")
|
||||
}
|
||||
|
||||
private fun setImmediateRxSchedulers() {
|
||||
val trampoline = { _: Scheduler -> Schedulers.trampoline() }
|
||||
RxJavaPlugins.setIoSchedulerHandler(trampoline)
|
||||
@@ -362,16 +622,28 @@ data class SendCall(
|
||||
val request: SendDmTextMessageRequest
|
||||
)
|
||||
|
||||
data class DisconnectCall(
|
||||
val authHeader: String,
|
||||
val roomId: Long
|
||||
)
|
||||
|
||||
data class RealtimeConnectCall(
|
||||
val token: String,
|
||||
val roomId: Long
|
||||
)
|
||||
|
||||
class FakeDmChatApi : DmChatApi {
|
||||
val createCalls = mutableListOf<CreateCall>()
|
||||
val openCalls = mutableListOf<OpenCall>()
|
||||
val messagesCalls = mutableListOf<MessagesCall>()
|
||||
val sendCalls = mutableListOf<SendCall>()
|
||||
val disconnectCalls = mutableListOf<DisconnectCall>()
|
||||
|
||||
private val createResponses = ArrayDeque<Single<ApiResponse<CreateDmChatRoomResponse>>>()
|
||||
private val openResponses = ArrayDeque<Single<ApiResponse<DmChatRoomOpenResponse>>>()
|
||||
private val messagesResponses = ArrayDeque<Single<ApiResponse<DmChatMessagesPageResponse>>>()
|
||||
private val sendResponses = ArrayDeque<Single<ApiResponse<SendDmChatMessageResponse>>>()
|
||||
private val disconnectResponses = ArrayDeque<Single<ApiResponse<Boolean>>>()
|
||||
|
||||
fun enqueueCreateSuccess(response: CreateDmChatRoomResponse) {
|
||||
createResponses.addLast(Single.just(ApiResponse(success = true, data = response)))
|
||||
@@ -393,6 +665,14 @@ class FakeDmChatApi : DmChatApi {
|
||||
sendResponses.addLast(response)
|
||||
}
|
||||
|
||||
fun enqueueDisconnect(response: Single<ApiResponse<Boolean>>) {
|
||||
disconnectResponses.addLast(response)
|
||||
}
|
||||
|
||||
fun enqueueDisconnectSuccess() {
|
||||
disconnectResponses.addLast(Single.just(ApiResponse(success = true, data = true)))
|
||||
}
|
||||
|
||||
fun enqueueSendSuccess(message: DmChatMessageResponse) {
|
||||
sendResponses.addLast(
|
||||
Single.just(
|
||||
@@ -447,5 +727,28 @@ class FakeDmChatApi : DmChatApi {
|
||||
override fun disconnectRealtime(
|
||||
authHeader: String,
|
||||
roomId: Long
|
||||
): Single<ApiResponse<Boolean>> = Single.just(ApiResponse(success = true, data = true))
|
||||
): Single<ApiResponse<Boolean>> {
|
||||
disconnectCalls.add(DisconnectCall(authHeader, roomId))
|
||||
return disconnectResponses.removeFirstOrNull() ?: Single.just(ApiResponse(success = true, data = true))
|
||||
}
|
||||
}
|
||||
|
||||
class FakeDmChatRealtimeClient : DmChatRealtimeClient {
|
||||
val connectCalls = mutableListOf<RealtimeConnectCall>()
|
||||
var cancelCalls = 0
|
||||
var listener: DmChatEventClient.Listener? = null
|
||||
|
||||
override fun connect(
|
||||
token: String,
|
||||
roomId: Long,
|
||||
listener: DmChatEventClient.Listener
|
||||
) {
|
||||
connectCalls.add(RealtimeConnectCall(token, roomId))
|
||||
this.listener = listener
|
||||
}
|
||||
|
||||
override fun cancel() {
|
||||
cancelCalls += 1
|
||||
listener = null
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user