refactor(content): 상세 진입을 공통 액션으로 통합한다
This commit is contained in:
@@ -0,0 +1,193 @@
|
||||
package kr.co.vividnext.sodalive.v2.content.action
|
||||
|
||||
import android.app.Activity
|
||||
import kr.co.vividnext.sodalive.audio_content.detail.AudioContentDetailActivity
|
||||
import kr.co.vividnext.sodalive.audio_content.series.detail.SeriesDetailActivity
|
||||
import kr.co.vividnext.sodalive.common.Constants
|
||||
import kr.co.vividnext.sodalive.v2.access.AccessRequirement
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertNull
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import org.robolectric.Robolectric
|
||||
import org.robolectric.RobolectricTestRunner
|
||||
import org.robolectric.Shadows.shadowOf
|
||||
import org.robolectric.annotation.Config
|
||||
import java.io.File
|
||||
|
||||
@RunWith(RobolectricTestRunner::class)
|
||||
@Config(application = android.app.Application::class)
|
||||
class ContentActionTest {
|
||||
|
||||
private val action = ContentAction()
|
||||
|
||||
@Test
|
||||
fun `유효하지 않은 ID는 Access를 확인하지 않고 무시한다`() {
|
||||
var accessCheckCount = 0
|
||||
val commands = listOf(
|
||||
ContentActionCommand.AudioDetail(audioContentId = 0L),
|
||||
ContentActionCommand.SeriesDetail(seriesId = -1L)
|
||||
)
|
||||
|
||||
val results = commands.map { command ->
|
||||
action.execute(command) {
|
||||
accessCheckCount += 1
|
||||
true
|
||||
}
|
||||
}
|
||||
|
||||
assertEquals(listOf(ContentActionResult.Ignored, ContentActionResult.Ignored), results)
|
||||
assertEquals(0, accessCheckCount)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `오디오 상세는 로그인 Access가 허용되면 navigation 결과를 반환한다`() {
|
||||
var capturedRequirement: AccessRequirement? = null
|
||||
|
||||
val result = action.execute(ContentActionCommand.AudioDetail(audioContentId = 11L)) { requirement ->
|
||||
capturedRequirement = requirement
|
||||
true
|
||||
}
|
||||
|
||||
assertEquals(AccessRequirement.Login, capturedRequirement)
|
||||
assertEquals(ContentActionResult.NavigateToAudioDetail(audioContentId = 11L), result)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `성인 시리즈 상세는 성인 Access가 허용되면 navigation 결과를 반환한다`() {
|
||||
var capturedRequirement: AccessRequirement? = null
|
||||
|
||||
val result = action.execute(
|
||||
ContentActionCommand.SeriesDetail(
|
||||
seriesId = 22L,
|
||||
requiresAdultContentAccess = true
|
||||
)
|
||||
) { requirement ->
|
||||
capturedRequirement = requirement
|
||||
true
|
||||
}
|
||||
|
||||
assertEquals(AccessRequirement.AdultContent, capturedRequirement)
|
||||
assertEquals(ContentActionResult.NavigateToSeriesDetail(seriesId = 22L), result)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `Access가 거부되면 차단 결과를 반환한다`() {
|
||||
val result = action.execute(
|
||||
ContentActionCommand.AudioDetail(
|
||||
audioContentId = 33L,
|
||||
requiresAdultContentAccess = true
|
||||
)
|
||||
) { false }
|
||||
|
||||
assertEquals(ContentActionResult.Blocked(AccessRequirement.AdultContent), result)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `Handler는 허용된 오디오 상세에 기존 ID extra를 전달한다`() {
|
||||
val activity = Robolectric.buildActivity(Activity::class.java).setup().get()
|
||||
|
||||
val result = ContentActionHandler().handle(
|
||||
context = activity,
|
||||
command = ContentActionCommand.AudioDetail(audioContentId = 44L),
|
||||
ensureAccess = { true }
|
||||
)
|
||||
val intent = shadowOf(activity).nextStartedActivity
|
||||
|
||||
assertEquals(ContentActionResult.NavigateToAudioDetail(audioContentId = 44L), result)
|
||||
assertEquals(AudioContentDetailActivity::class.java.name, intent.component?.className)
|
||||
assertEquals(44L, intent.getLongExtra(Constants.EXTRA_AUDIO_CONTENT_ID, 0L))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `Handler는 허용된 시리즈 상세에 기존 ID extra를 전달한다`() {
|
||||
val activity = Robolectric.buildActivity(Activity::class.java).setup().get()
|
||||
|
||||
val result = ContentActionHandler().handle(
|
||||
context = activity,
|
||||
command = ContentActionCommand.SeriesDetail(seriesId = 55L),
|
||||
ensureAccess = { true }
|
||||
)
|
||||
val intent = shadowOf(activity).nextStartedActivity
|
||||
|
||||
assertEquals(ContentActionResult.NavigateToSeriesDetail(seriesId = 55L), result)
|
||||
assertEquals(SeriesDetailActivity::class.java.name, intent.component?.className)
|
||||
assertEquals(55L, intent.getLongExtra(Constants.EXTRA_SERIES_ID, 0L))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `Handler는 차단 결과에서 Activity를 시작하지 않는다`() {
|
||||
val activity = Robolectric.buildActivity(Activity::class.java).setup().get()
|
||||
|
||||
val result = ContentActionHandler().handle(
|
||||
context = activity,
|
||||
command = ContentActionCommand.AudioDetail(audioContentId = 66L),
|
||||
ensureAccess = { false }
|
||||
)
|
||||
|
||||
assertEquals(ContentActionResult.Blocked(AccessRequirement.Login), result)
|
||||
assertNull(shadowOf(activity).nextStartedActivity)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `대상 화면은 상세 Activity 대신 Content Action을 사용한다`() {
|
||||
val actionSources = listOf(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/home/HomeMainFragment.kt",
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/content/ContentMainFragment.kt",
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/content/overview/ContentOverviewActivity.kt",
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/creator/channel/CreatorChannelActivity.kt"
|
||||
).map { path -> projectFile(path).readText() }
|
||||
val navigationOwnerSources = actionSources + listOf(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/home/model/HomeRecommendationUiModels.kt",
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/content/model/AudioRecommendationsUiModels.kt"
|
||||
).map { path -> projectFile(path).readText() }
|
||||
|
||||
actionSources.forEach { source ->
|
||||
assertTrue(source.contains("handleContentAction("))
|
||||
}
|
||||
navigationOwnerSources.forEach { source ->
|
||||
assertFalse(source.contains("AudioContentDetailActivity"))
|
||||
assertFalse(source.contains("SeriesDetailActivity"))
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `Creator tab은 알고 있는 성인 여부를 Content Action까지 전달한다`() {
|
||||
val audioFragmentSource = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/creator/channel/audio/CreatorChannelAudioFragment.kt"
|
||||
).readText()
|
||||
val liveFragmentSource = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/creator/channel/live/CreatorChannelLiveFragment.kt"
|
||||
).readText()
|
||||
val seriesFragmentSource = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/creator/channel/series/CreatorChannelSeriesFragment.kt"
|
||||
).readText()
|
||||
|
||||
assertTrue(
|
||||
audioFragmentSource.contains(
|
||||
"host.onCreatorChannelAudioContentClicked(item.audioContentId, item.showAdultBadge)"
|
||||
)
|
||||
)
|
||||
assertTrue(
|
||||
liveFragmentSource.contains(
|
||||
"host.onCreatorChannelLiveReplayClicked(item.audioContentId, item.showAdultBadge)"
|
||||
)
|
||||
)
|
||||
assertTrue(
|
||||
seriesFragmentSource.contains(
|
||||
"host.onCreatorChannelSeriesClicked(item.seriesId, item.showAdultBadge)"
|
||||
)
|
||||
)
|
||||
}
|
||||
|
||||
private fun projectFile(relativePath: String): File {
|
||||
val userDir = requireNotNull(System.getProperty("user.dir"))
|
||||
val fromRoot = File(userDir, relativePath)
|
||||
if (fromRoot.exists()) return fromRoot
|
||||
|
||||
val projectRoot = requireNotNull(File(userDir).parentFile)
|
||||
return projectRoot.resolve(relativePath)
|
||||
}
|
||||
}
|
||||
+17
-10
@@ -601,8 +601,11 @@ class CreatorChannelActivitySourceTest {
|
||||
assertTrue(source.contains("position == CreatorChannelTab.Series.ordinal"))
|
||||
assertTrue(source.contains("findSeriesFragment()?.onCreatorChannelSeriesViewportHeightChanged(minHeight)"))
|
||||
assertTrue(source.contains("override fun onCreatorChannelSeriesContentChanged()"))
|
||||
assertTrue(source.contains("override fun onCreatorChannelSeriesClicked(seriesId: Long)"))
|
||||
assertTrue(source.contains("putExtra(Constants.EXTRA_SERIES_ID, seriesId)"))
|
||||
assertTrue(source.contains("override fun onCreatorChannelSeriesClicked("))
|
||||
assertTrue(source.contains("seriesId: Long"))
|
||||
assertTrue(source.contains("requiresAdultContentAccess: Boolean"))
|
||||
assertTrue(source.contains("ContentActionCommand.SeriesDetail("))
|
||||
assertTrue(source.contains("requiresAdultContentAccess = requiresAdultContentAccess"))
|
||||
}
|
||||
|
||||
@Test
|
||||
@@ -1582,8 +1585,9 @@ class CreatorChannelActivitySourceTest {
|
||||
assertTrue(source.contains("private fun onScheduleClicked(schedule: CreatorChannelScheduleResponse)"))
|
||||
assertTrue(source.contains("CreatorActivityType.Audio"))
|
||||
assertTrue(source.contains("CreatorActivityType.LiveReplay"))
|
||||
assertTrue(source.contains("AudioContentDetailActivity::class.java"))
|
||||
assertTrue(source.contains("putExtra(Constants.EXTRA_AUDIO_CONTENT_ID, schedule.targetId)"))
|
||||
assertTrue(source.contains("openAudioContentDetail(schedule.targetId)"))
|
||||
assertTrue(source.contains("ContentActionCommand.AudioDetail("))
|
||||
assertFalse(source.contains("AudioContentDetailActivity"))
|
||||
assertTrue(source.contains("CreatorActivityType.Live"))
|
||||
assertTrue(source.contains("CreatorActivityType.Live -> liveCoordinator.showLiveRoomDetail(schedule.targetId)"))
|
||||
}
|
||||
@@ -1679,9 +1683,12 @@ class CreatorChannelActivitySourceTest {
|
||||
assertTrue(fragment.contains("private fun onAudioContentClicked(audioContent: CreatorChannelAudioContentResponse)"))
|
||||
assertTrue(fragment.contains("host.onCreatorChannelAudioContentClicked(audioContent)"))
|
||||
assertTrue(source.contains("private fun onAudioContentClicked(audioContent: CreatorChannelAudioContentResponse)"))
|
||||
assertTrue(source.contains("AudioContentDetailActivity::class.java"))
|
||||
assertTrue(source.contains("startAudioContentDetail(audioContent.audioContentId)"))
|
||||
assertTrue(source.contains("putExtra(Constants.EXTRA_AUDIO_CONTENT_ID, audioContentId)"))
|
||||
assertTrue(
|
||||
source.contains("openAudioContentDetail(audioContent.audioContentId, audioContent.isAdult)")
|
||||
)
|
||||
assertTrue(source.contains("ContentActionCommand.AudioDetail("))
|
||||
assertTrue(source.contains("requiresAdultContentAccess = requiresAdultContentAccess"))
|
||||
assertFalse(source.contains("AudioContentDetailActivity"))
|
||||
}
|
||||
|
||||
@Test
|
||||
@@ -1816,10 +1823,10 @@ class CreatorChannelActivitySourceTest {
|
||||
assertTrue(fragment.contains("onSeriesClick = ::onSeriesClicked"))
|
||||
assertTrue(fragment.contains("private fun onSeriesClicked(series: CreatorChannelSeriesResponse)"))
|
||||
assertTrue(fragment.contains("host.onCreatorChannelSeriesClicked(series)"))
|
||||
assertTrue(source.contains("import kr.co.vividnext.sodalive.audio_content.series.detail.SeriesDetailActivity"))
|
||||
assertTrue(source.contains("private fun onSeriesClicked(series: CreatorChannelSeriesResponse)"))
|
||||
assertTrue(source.contains("SeriesDetailActivity::class.java"))
|
||||
assertTrue(source.contains("putExtra(Constants.EXTRA_SERIES_ID, series.seriesId)"))
|
||||
assertTrue(source.contains("openSeriesDetail(series.seriesId)"))
|
||||
assertTrue(source.contains("ContentActionCommand.SeriesDetail("))
|
||||
assertFalse(source.contains("SeriesDetailActivity"))
|
||||
}
|
||||
|
||||
@Test
|
||||
|
||||
+2
@@ -117,6 +117,8 @@ class CreatorChannelSeriesFragmentLayoutTest {
|
||||
assertTrue(adapter.contains("R.string.creator_channel_series_subtitle_content_count"))
|
||||
assertTrue(adapter.contains("R.string.creator_channel_series_status_proceeding"))
|
||||
assertTrue(adapter.contains("R.string.creator_channel_series_status_completed"))
|
||||
assertTrue(fragment.contains("host.onCreatorChannelSeriesClicked(item.seriesId, item.showAdultBadge)"))
|
||||
assertTrue(adapter.contains("onSeriesClicked(item)"))
|
||||
assertTrue(!adapter.contains("tvCreatorChannelSeriesSubtitle.text = item.subtitle"))
|
||||
}
|
||||
|
||||
|
||||
+29
-36
@@ -8,27 +8,39 @@ import java.io.File
|
||||
class ContentMainFragmentLoginGuardSourceTest {
|
||||
|
||||
@Test
|
||||
fun `ContentMainFragment 실제 이동은 MainV2 로그인 가드를 통과한다`() {
|
||||
val source = projectFile(
|
||||
fun `ContentMainFragment 상세 이동은 공통 Content Action Access를 통과한다`() {
|
||||
val fragmentSource = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/content/ContentMainFragment.kt"
|
||||
).readText()
|
||||
val handlerSource = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/content/action/ContentActionHandler.kt"
|
||||
).readText()
|
||||
|
||||
assertTrue(source.contains("import kr.co.vividnext.sodalive.v2.access.ensureV2Access"))
|
||||
assertGuardedStartActivity(source, "private fun onBannerClick(item: ContentBannerUiModel)")
|
||||
assertGuardedStartActivity(source, "audioContentId: Long,\n requiresAdultContentAccess: Boolean = false")
|
||||
assertGuardedStartActivity(source, "seriesId: Long,\n requiresAdultContentAccess: Boolean = false")
|
||||
assertFalse(source.contains("kr.co.vividnext.sodalive.main.MainActivity"))
|
||||
assertTrue(fragmentSource.contains("import kr.co.vividnext.sodalive.v2.content.action.handleContentAction"))
|
||||
assertTrue(fragmentSource.contains("ContentActionCommand.AudioDetail("))
|
||||
assertTrue(fragmentSource.contains("ContentActionCommand.SeriesDetail("))
|
||||
assertTrue(handlerSource.contains("action.execute(command, ensureAccess)"))
|
||||
assertTrue(
|
||||
handlerSource.indexOf("action.execute(command, ensureAccess)") <
|
||||
handlerSource.indexOf("context.startActivity(")
|
||||
)
|
||||
assertFalse(fragmentSource.contains("kr.co.vividnext.sodalive.main.MainActivity"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `ContentMainFragment invalid id return은 로그인 가드보다 먼저 유지된다`() {
|
||||
val source = projectFile(
|
||||
fun `Content Action invalid ID 결과는 Access 확인보다 먼저 유지된다`() {
|
||||
val fragmentSource = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/content/ContentMainFragment.kt"
|
||||
).readText()
|
||||
val actionSource = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/content/action/ContentAction.kt"
|
||||
).readText()
|
||||
|
||||
assertBeforeGuard(source, "val route = item.toContentBannerRoute() ?: return")
|
||||
assertBeforeGuard(source, "if (audioContentId <= 0L) return")
|
||||
assertBeforeGuard(source, "if (seriesId <= 0L) return")
|
||||
assertTrue(fragmentSource.contains("val route = item.toContentBannerRoute() ?: return"))
|
||||
assertTrue(
|
||||
actionSource.indexOf("if (!isValidId) return ContentActionResult.Ignored") <
|
||||
actionSource.indexOf("if (!ensureAccess(requirement))")
|
||||
)
|
||||
}
|
||||
|
||||
@Test
|
||||
@@ -40,34 +52,15 @@ class ContentMainFragmentLoginGuardSourceTest {
|
||||
assertTrue(source.contains("openAudioContentDetail(item.audioContentId, item.showAdultBadge)"))
|
||||
assertTrue(source.contains("openAudioContentDetail(audioContentId, findAllTabAudioAdultAccess(audioContentId))"))
|
||||
assertTrue(source.contains("openSeriesDetail(seriesId, findAllTabSeriesAdultAccess(seriesId))"))
|
||||
assertTrue(source.contains("AccessRequirement.forAdultContent(requiresAdultContentAccess)"))
|
||||
val actionSource = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/content/action/ContentAction.kt"
|
||||
).readText()
|
||||
|
||||
assertTrue(actionSource.contains("AccessRequirement.forAdultContent(requiresAdultContentAccess)"))
|
||||
assertFalse(source.contains("ContentCommentedAudioUiModel.showAdultBadge"))
|
||||
assertFalse(source.contains("ContentOriginalSeriesUiModel.showAdultBadge"))
|
||||
}
|
||||
|
||||
private fun assertGuardedStartActivity(source: String, functionSignature: String) {
|
||||
val functionSource = source.substringFrom(functionSignature)
|
||||
assertTrue(
|
||||
"$functionSignature must call ensureV2Access before startActivity.",
|
||||
functionSource.indexOf("ensureV2Access") in 0 until functionSource.indexOf("startActivity")
|
||||
)
|
||||
}
|
||||
|
||||
private fun assertBeforeGuard(source: String, expectedReturn: String) {
|
||||
val returnIndex = source.indexOf(expectedReturn)
|
||||
val guardIndex = source.indexOf("ensureV2Access", returnIndex)
|
||||
|
||||
assertTrue("Missing source: $expectedReturn", returnIndex >= 0)
|
||||
assertTrue("$expectedReturn must stay before guard.", guardIndex > returnIndex)
|
||||
}
|
||||
|
||||
private fun String.substringFrom(marker: String): String {
|
||||
val startIndex = indexOf(marker)
|
||||
assertTrue("Missing function: $marker", startIndex >= 0)
|
||||
val nextFunctionIndex = indexOf("\n private fun ", startIndex + marker.length).takeIf { it >= 0 } ?: length
|
||||
return substring(startIndex, nextFunctionIndex)
|
||||
}
|
||||
|
||||
private fun projectFile(relativePath: String): File {
|
||||
val candidates = listOf(File(relativePath), File("../$relativePath"))
|
||||
return candidates.firstOrNull { it.exists() }
|
||||
|
||||
+22
-18
@@ -3,7 +3,6 @@ package kr.co.vividnext.sodalive.v2.main.content
|
||||
import android.app.Application
|
||||
import android.content.Context
|
||||
import kr.co.vividnext.sodalive.BuildConfig
|
||||
import kr.co.vividnext.sodalive.audio_content.series.detail.SeriesDetailActivity
|
||||
import kr.co.vividnext.sodalive.common.Constants
|
||||
import kr.co.vividnext.sodalive.settings.event.EventDetailActivity
|
||||
import kr.co.vividnext.sodalive.settings.event.EventItem
|
||||
@@ -14,6 +13,7 @@ import kr.co.vividnext.sodalive.v2.main.content.model.toContentBannerIntent
|
||||
import kr.co.vividnext.sodalive.v2.main.content.model.toContentBannerRoute
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertNull
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
@@ -140,7 +140,7 @@ class ContentMainFragmentSourceTest {
|
||||
assertTrue(source.contains("loadMore()"))
|
||||
assertTrue(source.contains("consumePaginationErrorMessage()"))
|
||||
assertTrue(source.contains("openAudioContentDetail(audioContentId)"))
|
||||
assertTrue(source.contains("openSeriesDetail(seriesId)"))
|
||||
assertTrue(source.contains("openSeriesDetail(seriesId, findAllTabSeriesAdultAccess(seriesId))"))
|
||||
assertTrue(source.contains("override fun onDestroyView()"))
|
||||
assertTrue(source.contains("sortPopup?.dismiss()"))
|
||||
assertTrue(source.contains("sortPopup = null"))
|
||||
@@ -240,27 +240,28 @@ class ContentMainFragmentSourceTest {
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `content 추천 source는 오디오와 시리즈 routing extra를 사용한다`() {
|
||||
fun `content 추천 source는 오디오와 시리즈 상세를 Content Action에 위임한다`() {
|
||||
val source = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/content/ContentMainFragment.kt"
|
||||
).readText()
|
||||
|
||||
assertTrue(source.contains("AudioContentDetailActivity::class.java"))
|
||||
assertTrue(source.contains("putExtra(Constants.EXTRA_AUDIO_CONTENT_ID, audioContentId)"))
|
||||
assertTrue(source.contains("SeriesDetailActivity::class.java"))
|
||||
assertTrue(source.contains("putExtra(Constants.EXTRA_SERIES_ID, seriesId)"))
|
||||
assertTrue(source.contains("handleContentAction("))
|
||||
assertTrue(source.contains("ContentActionCommand.AudioDetail("))
|
||||
assertTrue(source.contains("ContentActionCommand.SeriesDetail("))
|
||||
assertFalse(source.contains("AudioContentDetailActivity"))
|
||||
assertFalse(source.contains("SeriesDetailActivity"))
|
||||
assertTrue(source.contains("toContentBannerRoute()"))
|
||||
assertTrue(source.contains("toContentBannerIntent(requireContext())"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `content 랭킹 routing은 유효하지 않은 contentId를 무시한다`() {
|
||||
fun `content 랭킹 routing은 숫자가 아닌 contentId를 무시한다`() {
|
||||
val source = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/content/ContentMainFragment.kt"
|
||||
).readText()
|
||||
|
||||
assertTrue(source.contains("private fun openRankingAudioContentDetail(item: ContentRankingItem)"))
|
||||
assertTrue(source.contains("item.contentId.toLongOrNull()?.takeIf { it > 0L } ?: return"))
|
||||
assertTrue(source.contains("item.contentId.toLongOrNull() ?: return"))
|
||||
assertTrue(source.contains("openAudioContentDetail(audioContentId)"))
|
||||
}
|
||||
|
||||
@@ -465,21 +466,24 @@ class ContentMainFragmentSourceTest {
|
||||
fun `content banner route creates expected intents`() {
|
||||
val context = RuntimeEnvironment.getApplication() as Context
|
||||
val eventItem = EventItem(id = 1L, thumbnailImageUrl = "https://example.com/event.png")
|
||||
val eventIntent = ContentBannerRoute.Event(eventItem).toContentBannerIntent(context)
|
||||
val creatorIntent = ContentBannerRoute.Creator(2L).toContentBannerIntent(context)
|
||||
val eventIntent = requireNotNull(ContentBannerRoute.Event(eventItem).toContentBannerIntent(context))
|
||||
val creatorIntent = requireNotNull(ContentBannerRoute.Creator(2L).toContentBannerIntent(context))
|
||||
val seriesIntent = ContentBannerRoute.Series(3L).toContentBannerIntent(context)
|
||||
val webIntent = ContentBannerRoute.Link("https://example.com", isWebUrl = true).toContentBannerIntent(context)
|
||||
val deepLinkIntent = ContentBannerRoute.Link(
|
||||
url = "${BuildConfig.APPSCHEME}://series/3",
|
||||
isWebUrl = false
|
||||
).toContentBannerIntent(context)
|
||||
val webIntent = requireNotNull(
|
||||
ContentBannerRoute.Link("https://example.com", isWebUrl = true).toContentBannerIntent(context)
|
||||
)
|
||||
val deepLinkIntent = requireNotNull(
|
||||
ContentBannerRoute.Link(
|
||||
url = "${BuildConfig.APPSCHEME}://series/3",
|
||||
isWebUrl = false
|
||||
).toContentBannerIntent(context)
|
||||
)
|
||||
|
||||
assertEquals(EventDetailActivity::class.java.name, eventIntent.component?.className)
|
||||
assertEquals(eventItem, eventIntent.getParcelableExtra(Constants.EXTRA_EVENT))
|
||||
assertEquals(CreatorChannelActivity::class.java.name, creatorIntent.component?.className)
|
||||
assertEquals(2L, creatorIntent.getLongExtra(CreatorChannelActivity.EXTRA_CREATOR_ID, 0L))
|
||||
assertEquals(SeriesDetailActivity::class.java.name, seriesIntent.component?.className)
|
||||
assertEquals(3L, seriesIntent.getLongExtra(Constants.EXTRA_SERIES_ID, 0L))
|
||||
assertNull(seriesIntent)
|
||||
assertEquals(android.content.Intent.ACTION_VIEW, webIntent.action)
|
||||
assertEquals("https://example.com", webIntent.data.toString())
|
||||
assertEquals(android.content.Intent.ACTION_VIEW, deepLinkIntent.action)
|
||||
|
||||
+10
-7
@@ -1,6 +1,7 @@
|
||||
package kr.co.vividnext.sodalive.v2.main.content.overview
|
||||
|
||||
import android.app.Application
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
@@ -63,24 +64,26 @@ class ContentOverviewActivitySourceTest {
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `ContentOverviewActivity opens audio detail with content id`() {
|
||||
fun `ContentOverviewActivity는 ID와 성인 여부를 Content Action에 전달한다`() {
|
||||
val source = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/content/overview/ContentOverviewActivity.kt"
|
||||
).readText()
|
||||
|
||||
assertTrue(source.contains("AudioContentDetailActivity::class.java"))
|
||||
assertTrue(source.contains("if (contentId <= 0) return"))
|
||||
assertTrue(source.contains("putExtra(Constants.EXTRA_AUDIO_CONTENT_ID, contentId)"))
|
||||
assertTrue(source.contains("handleContentAction("))
|
||||
assertTrue(source.contains("ContentActionCommand.AudioDetail("))
|
||||
assertTrue(source.contains("audioContentId = item.contentId"))
|
||||
assertTrue(source.contains("requiresAdultContentAccess = item.showAdultBadge"))
|
||||
assertFalse(source.contains("AudioContentDetailActivity"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `ContentOverviewAdapter ignores invalid content id clicks`() {
|
||||
fun `ContentOverviewAdapter는 Action 검증을 위해 전체 항목을 전달한다`() {
|
||||
val source = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/content/overview/ui/ContentOverviewAdapter.kt"
|
||||
).readText()
|
||||
|
||||
assertTrue(source.contains("if (item.contentId <= 0) return@setOnClickListener"))
|
||||
assertTrue(source.contains("onContentClick(item.contentId)"))
|
||||
assertTrue(source.contains("onContentClick(item)"))
|
||||
assertFalse(source.contains("if (item.contentId <= 0)"))
|
||||
}
|
||||
|
||||
@Test
|
||||
|
||||
+32
-26
@@ -23,14 +23,11 @@ import androidx.recyclerview.widget.RecyclerView
|
||||
import androidx.test.core.app.ApplicationProvider
|
||||
import kr.co.vividnext.sodalive.R
|
||||
import kr.co.vividnext.sodalive.BuildConfig
|
||||
import kr.co.vividnext.sodalive.audio_content.detail.AudioContentDetailActivity
|
||||
import kr.co.vividnext.sodalive.audio_content.series.detail.SeriesDetailActivity
|
||||
import kr.co.vividnext.sodalive.common.Constants
|
||||
import kr.co.vividnext.sodalive.common.formatUtcRelativeTimeText
|
||||
import kr.co.vividnext.sodalive.settings.event.EventDetailActivity
|
||||
import kr.co.vividnext.sodalive.settings.event.EventItem
|
||||
import kr.co.vividnext.sodalive.v2.creator.channel.CreatorChannelActivity
|
||||
import kr.co.vividnext.sodalive.v2.creator.channel.community.detail.CreatorChannelCommunityDetailActivity
|
||||
import kr.co.vividnext.sodalive.v2.main.home.data.HomeActiveCreatorItem
|
||||
import kr.co.vividnext.sodalive.v2.main.home.data.HomeAiCharacterItem
|
||||
import kr.co.vividnext.sodalive.v2.main.home.data.HomeBannerItem
|
||||
@@ -61,7 +58,6 @@ import kr.co.vividnext.sodalive.v2.main.home.model.toHomeRecommendationBannerInt
|
||||
import kr.co.vividnext.sodalive.v2.main.home.model.toHomeRecommendationBannerRoute
|
||||
import kr.co.vividnext.sodalive.v2.main.home.model.toHomeRecommendationAiCharacterIntent
|
||||
import kr.co.vividnext.sodalive.v2.main.home.model.toHomeRecommendationAiCharacterRoute
|
||||
import kr.co.vividnext.sodalive.v2.main.home.model.toHomeRecommendationRecentlyActiveCreatorIntent
|
||||
import kr.co.vividnext.sodalive.v2.main.home.model.toHomeRecommendationRecentlyActiveCreatorRoute
|
||||
import kr.co.vividnext.sodalive.v2.main.home.model.visibleHomePopularCommunityPosts
|
||||
import kr.co.vividnext.sodalive.v2.main.home.model.visibleHomeGenreCreatorGroups
|
||||
@@ -84,6 +80,7 @@ import kr.co.vividnext.sodalive.v2.main.home.model.toUiModel
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertNotNull
|
||||
import org.junit.Assert.assertNull
|
||||
import org.junit.Assert.assertSame
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Test
|
||||
@@ -872,24 +869,31 @@ class HomeMainFragmentLayoutTest {
|
||||
fun `home banner route creates activity and link intents with expected extras`() {
|
||||
val context = ApplicationProvider.getApplicationContext<Context>()
|
||||
val eventItem = EventItem(id = 1L, thumbnailImageUrl = "https://example.com/event.png")
|
||||
val eventIntent = HomeRecommendationBannerRoute.Event(eventItem).toHomeRecommendationBannerIntent(context)
|
||||
val creatorIntent = HomeRecommendationBannerRoute.Creator(2L).toHomeRecommendationBannerIntent(context)
|
||||
val eventIntent = requireNotNull(
|
||||
HomeRecommendationBannerRoute.Event(eventItem).toHomeRecommendationBannerIntent(context)
|
||||
)
|
||||
val creatorIntent = requireNotNull(
|
||||
HomeRecommendationBannerRoute.Creator(2L).toHomeRecommendationBannerIntent(context)
|
||||
)
|
||||
val seriesIntent = HomeRecommendationBannerRoute.Series(3L).toHomeRecommendationBannerIntent(context)
|
||||
val webIntent = HomeRecommendationBannerRoute.Link(
|
||||
url = "https://example.com",
|
||||
isWebUrl = true
|
||||
).toHomeRecommendationBannerIntent(context)
|
||||
val deepLinkIntent = HomeRecommendationBannerRoute.Link(
|
||||
url = "${BuildConfig.APPSCHEME}://series/3",
|
||||
isWebUrl = false
|
||||
).toHomeRecommendationBannerIntent(context)
|
||||
val webIntent = requireNotNull(
|
||||
HomeRecommendationBannerRoute.Link(
|
||||
url = "https://example.com",
|
||||
isWebUrl = true
|
||||
).toHomeRecommendationBannerIntent(context)
|
||||
)
|
||||
val deepLinkIntent = requireNotNull(
|
||||
HomeRecommendationBannerRoute.Link(
|
||||
url = "${BuildConfig.APPSCHEME}://series/3",
|
||||
isWebUrl = false
|
||||
).toHomeRecommendationBannerIntent(context)
|
||||
)
|
||||
|
||||
assertEquals(EventDetailActivity::class.java.name, eventIntent.component?.className)
|
||||
assertEquals(eventItem, eventIntent.getParcelableExtra(Constants.EXTRA_EVENT))
|
||||
assertEquals(CreatorChannelActivity::class.java.name, creatorIntent.component?.className)
|
||||
assertEquals(2L, creatorIntent.getLongExtra(CreatorChannelActivity.EXTRA_CREATOR_ID, 0L))
|
||||
assertEquals(SeriesDetailActivity::class.java.name, seriesIntent.component?.className)
|
||||
assertEquals(3L, seriesIntent.getLongExtra(Constants.EXTRA_SERIES_ID, 0L))
|
||||
assertNull(seriesIntent)
|
||||
assertEquals(android.content.Intent.ACTION_VIEW, webIntent.action)
|
||||
assertEquals("https://example.com", webIntent.data.toString())
|
||||
assertEquals(android.content.Intent.ACTION_VIEW, deepLinkIntent.action)
|
||||
@@ -947,17 +951,19 @@ class HomeMainFragmentLayoutTest {
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `home recent activity route creates expected intents`() {
|
||||
val context = ApplicationProvider.getApplicationContext<Context>()
|
||||
val audioIntent = HomeRecommendationRecentlyActiveCreatorRoute.AudioContent(11L)
|
||||
.toHomeRecommendationRecentlyActiveCreatorIntent(context)
|
||||
val communityIntent = HomeRecommendationRecentlyActiveCreatorRoute.Community(13L)
|
||||
.toHomeRecommendationRecentlyActiveCreatorIntent(context)
|
||||
fun `home 오디오와 시리즈 route는 Content Action을 사용한다`() {
|
||||
val fragmentSource = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/home/HomeMainFragment.kt"
|
||||
).readText()
|
||||
val modelSource = projectFile(
|
||||
"app/src/main/java/kr/co/vividnext/sodalive/v2/main/home/model/HomeRecommendationUiModels.kt"
|
||||
).readText()
|
||||
|
||||
assertEquals(AudioContentDetailActivity::class.java.name, audioIntent.component?.className)
|
||||
assertEquals(11L, audioIntent.getLongExtra(Constants.EXTRA_AUDIO_CONTENT_ID, 0L))
|
||||
assertEquals(CreatorChannelCommunityDetailActivity::class.java.name, communityIntent.component?.className)
|
||||
assertEquals(13L, communityIntent.getLongExtra("extra_post_id", 0L))
|
||||
assertTrue(fragmentSource.contains("ContentActionCommand.AudioDetail("))
|
||||
assertTrue(fragmentSource.contains("ContentActionCommand.SeriesDetail("))
|
||||
assertTrue(fragmentSource.contains("handleContentAction("))
|
||||
assertFalse(modelSource.contains("AudioContentDetailActivity"))
|
||||
assertFalse(modelSource.contains("SeriesDetailActivity"))
|
||||
}
|
||||
|
||||
@Test
|
||||
|
||||
Reference in New Issue
Block a user