klaus/sodalive-backend-spring-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(content): 오디오 추천 조회 fallback을 섹션별로 적용한다

Browse Source
This commit is contained in:
klaus
2026-07-12 22:44:14 +09:00
parent d8fbf449c4
commit 91f0d20a79
2 changed files with 122 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/kotlin/kr/co/vividnext/sodalive/v2/content/recommendation/application/AudioRecommendationQueryServiceTest.kt
+96 -91
View File
@@ -7,30 +7,21 @@ import kr.co.vividnext.sodalive.v2.content.recommendation.domain.AudioCard
import kr.co.vividnext.sodalive.v2.content.recommendation.domain.AudioRecommendationVisibility
import kr.co.vividnext.sodalive.v2.content.recommendation.port.out.AudioRecommendationQueryPort
import kr.co.vividnext.sodalive.v2.recommendation.domain.RecommendedSectionType
import kr.co.vividnext.sodalive.v2.recommendation.port.out.RecommendationSnapshotPort
import kr.co.vividnext.sodalive.v2.recommendation.port.out.RecommendationSnapshotRecord
import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.DisplayName
import org.junit.jupiter.api.Test
import org.mockito.Mockito
import org.redisson.api.RBucket
import org.redisson.api.RedissonClient
import java.time.Duration
import java.time.LocalDateTime
class AudioRecommendationQueryServiceTest {
private val queryPort = Mockito.mock(AudioRecommendationQueryPort::class.java)
private val preferenceService = Mockito.mock(MemberContentPreferenceService::class.java)
private val snapshotPort = Mockito.mock(RecommendationSnapshotPort::class.java)
private val refreshService = Mockito.mock(AudioRecommendationSnapshotRefreshService::class.java)
private val redissonClient = Mockito.mock(RedissonClient::class.java)
private val lazyRefreshMarker = Mockito.mock(RBucket::class.java) as RBucket<String>
private val fallbackService = Mockito.mock(AudioRecommendationSnapshotFallbackService::class.java)
private val service = AudioRecommendationQueryService(
queryPort,
preferenceService,
snapshotPort,
refreshService,
redissonClient
fallbackService
)
@Test
@@ -40,8 +31,8 @@ class AudioRecommendationQueryServiceTest {
}
@Test
@DisplayName("조회 서비스는 SAFE 스냅샷을 lazy refresh 후 상세 섹션으로 조립한다")
fun shouldBuildRecommendationsFromSafeSnapshotsWithLazyRefresh() {
@DisplayName("조회 서비스는 SAFE 스냅샷 기반 3개 섹션을 fallback 경로로 조립한다")
fun shouldBuildRecommendationsFromSafeSnapshotsWithFallback() {
val snapshot = RecommendationSnapshotRecord(
sectionType = RecommendedSectionType.NEW_AND_HOT_AUDIO_SAFE,
targetId = 1L,
@@ -49,39 +40,39 @@ class AudioRecommendationQueryServiceTest {
snapshotAt = LocalDateTime.now(),
randomTieBreaker = 1.0
)
Mockito.doReturn(emptyList<RecommendationSnapshotRecord>(), listOf(snapshot))
.`when`(snapshotPort)
.findLatestSnapshots(
RecommendedSectionType.NEW_AND_HOT_AUDIO_SAFE,
0,
AudioRecommendationQueryService.NEW_AND_HOT_HOME_LIMIT
)
Mockito.doReturn(emptyList<RecommendationSnapshotRecord>())
.`when`(snapshotPort)
.findLatestSnapshots(
RecommendedSectionType.MOST_COMMENTED_AUDIO_SAFE,
0,
AudioRecommendationQueryService.MOST_COMMENTED_AUDIO_LIMIT
)
Mockito.doReturn(emptyList<RecommendationSnapshotRecord>())
.`when`(snapshotPort)
.findLatestSnapshots(
RecommendedSectionType.RECOMMENDED_AUDIO_SAFE,
0,
AudioRecommendationQueryService.RECOMMENDED_AUDIO_LIMIT
)
allowLazyRefreshOnce()
stubFallback(
RecommendedSectionType.NEW_AND_HOT_AUDIO_SAFE,
0,
AudioRecommendationQueryService.NEW_AND_HOT_HOME_LIMIT,
listOf(snapshot)
)
stubFallback(
RecommendedSectionType.MOST_COMMENTED_AUDIO_SAFE,
0,
AudioRecommendationQueryService.MOST_COMMENTED_AUDIO_LIMIT,
emptyList()
)
stubFallback(
RecommendedSectionType.RECOMMENDED_AUDIO_SAFE,
0,
AudioRecommendationQueryService.RECOMMENDED_AUDIO_LIMIT,
emptyList()
)
val recommendations = service.getRecommendations(null)
assertEquals(0, recommendations.mostCommentedAudios.size)
Mockito.verify(refreshService).refreshDailySnapshots()
Mockito.verify(snapshotPort, Mockito.times(1)).findLatestSnapshots(
verifyFallback(
RecommendedSectionType.NEW_AND_HOT_AUDIO_SAFE,
0,
AudioRecommendationQueryService.NEW_AND_HOT_HOME_LIMIT
)
verifyFallback(
RecommendedSectionType.MOST_COMMENTED_AUDIO_SAFE,
0,
AudioRecommendationQueryService.MOST_COMMENTED_AUDIO_LIMIT
)
Mockito.verify(snapshotPort, Mockito.times(1)).findLatestSnapshots(
verifyFallback(
RecommendedSectionType.RECOMMENDED_AUDIO_SAFE,
0,
AudioRecommendationQueryService.RECOMMENDED_AUDIO_LIMIT
@@ -114,35 +105,34 @@ class AudioRecommendationQueryServiceTest {
}
@Test
@DisplayName("New & Hot lazy refresh는 보강 후에도 비어 있으면 같은 KST 날짜에 다시 실행하지 않는다")
fun shouldAttemptEmptyNewAndHotLazyRefreshOncePerKstDate() {
Mockito.doReturn(emptyList<RecommendationSnapshotRecord>())
.`when`(snapshotPort)
.findLatestSnapshots(
RecommendedSectionType.NEW_AND_HOT_AUDIO_SAFE,
0,
AudioRecommendationQueryService.NEW_AND_HOT_HOME_LIMIT
)
Mockito.doReturn(emptyList<RecommendationSnapshotRecord>())
.`when`(snapshotPort)
.findLatestSnapshots(
RecommendedSectionType.MOST_COMMENTED_AUDIO_SAFE,
0,
AudioRecommendationQueryService.MOST_COMMENTED_AUDIO_LIMIT
)
Mockito.doReturn(emptyList<RecommendationSnapshotRecord>())
.`when`(snapshotPort)
.findLatestSnapshots(
RecommendedSectionType.RECOMMENDED_AUDIO_SAFE,
0,
AudioRecommendationQueryService.RECOMMENDED_AUDIO_LIMIT
)
allowLazyRefreshOnce()
@DisplayName("Most Commented만 비어 있어도 해당 섹션 fallback을 독립적으로 호출한다")
fun shouldFallbackMostCommentedIndependentlyWhenNewAndHotExists() {
stubFallback(
RecommendedSectionType.NEW_AND_HOT_AUDIO_SAFE,
0,
AudioRecommendationQueryService.NEW_AND_HOT_HOME_LIMIT,
listOf(snapshot(RecommendedSectionType.NEW_AND_HOT_AUDIO_SAFE, 1L))
)
stubFallback(
RecommendedSectionType.MOST_COMMENTED_AUDIO_SAFE,
0,
AudioRecommendationQueryService.MOST_COMMENTED_AUDIO_LIMIT,
emptyList()
)
stubFallback(
RecommendedSectionType.RECOMMENDED_AUDIO_SAFE,
0,
AudioRecommendationQueryService.RECOMMENDED_AUDIO_LIMIT,
listOf(snapshot(RecommendedSectionType.RECOMMENDED_AUDIO_SAFE, 2L))
)
service.getRecommendations(null)
service.getRecommendations(null)
Mockito.verify(refreshService, Mockito.times(1)).refreshDailySnapshots()
verifyFallback(
RecommendedSectionType.MOST_COMMENTED_AUDIO_SAFE,
0,
AudioRecommendationQueryService.MOST_COMMENTED_AUDIO_LIMIT
)
}
@Test
@@ -150,19 +140,18 @@ class AudioRecommendationQueryServiceTest {
fun shouldUseStoredPreferenceForMemberAdultVisibility() {
val member = member(id = 10L)
Mockito.doReturn(true).`when`(preferenceService).canViewAdultContent(member)
Mockito.doReturn(listOf(snapshot(RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL, 10L)))
.`when`(snapshotPort)
.findLatestSnapshots(
RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL,
0,
AudioRecommendationQueryService.NEW_AND_HOT_HOME_LIMIT
)
stubFallback(
RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL,
0,
AudioRecommendationQueryService.NEW_AND_HOT_HOME_LIMIT,
listOf(snapshot(RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL, 10L))
)
service.getRecommendations(member)
Mockito.verify(preferenceService).canViewAdultContent(member)
Mockito.verify(preferenceService, Mockito.never()).initializeDefaultPreference(member)
Mockito.verify(snapshotPort).findLatestSnapshots(
verifyFallback(
RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL,
0,
AudioRecommendationQueryService.NEW_AND_HOT_HOME_LIMIT
@@ -174,16 +163,16 @@ class AudioRecommendationQueryServiceTest {
fun shouldKeepNewAndHotHomeLimitAtTwelve() {
val member = member(id = 10L)
Mockito.doReturn(true).`when`(preferenceService).canViewAdultContent(member)
Mockito.doReturn(listOf(snapshot(RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL, 10L))).`when`(snapshotPort)
.findLatestSnapshots(
RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL,
0,
AudioRecommendationQueryService.NEW_AND_HOT_HOME_LIMIT
)
stubFallback(
RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL,
0,
AudioRecommendationQueryService.NEW_AND_HOT_HOME_LIMIT,
listOf(snapshot(RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL, 10L))
)
service.getRecommendations(member)
Mockito.verify(snapshotPort).findLatestSnapshots(
verifyFallback(
RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL,
0,
AudioRecommendationQueryService.NEW_AND_HOT_HOME_LIMIT
@@ -200,15 +189,19 @@ class AudioRecommendationQueryServiceTest {
snapshot(RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL, 5L)
)
Mockito.doReturn(true).`when`(preferenceService).canViewAdultContent(member)
Mockito.doReturn(snapshots).`when`(snapshotPort)
.findLatestSnapshots(RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL, 20L, 21)
stubFallback(RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL, 20L, 21, snapshots)
Mockito.doReturn(listOf(audioCard(3L), audioCard(4L), audioCard(5L))).`when`(queryPort)
.findAudioCardsByIds(eqValue(listOf(3L, 4L, 5L)), eqValue(member.id), eqValue(true), anyLocalDateTime())
.findAudioCardsByIds(
eqValue(listOf(3L, 4L, 5L)),
eqValue(member.id),
eqValue(true),
anyLocalDateTime()
)
val result = service.findNewAndHotAudios(member, offset = 20L, limit = 21)
assertEquals(listOf(3L, 4L, 5L), result.map { it.audioContentId })
Mockito.verify(snapshotPort).findLatestSnapshots(RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL, 20L, 21)
verifyFallback(RecommendedSectionType.NEW_AND_HOT_AUDIO_ALL, 20L, 21)
}
@Test
@@ -280,15 +273,27 @@ class AudioRecommendationQueryServiceTest {
)
}
private fun stubFallback(
sectionType: RecommendedSectionType,
offset: Long,
limit: Int,
snapshots: List<RecommendationSnapshotRecord>
) {
Mockito.doReturn(snapshots)
.`when`(fallbackService)
.refreshIfMissing(eqValue(sectionType), eqValue(offset), eqValue(limit), anyLocalDateTime())
}
private fun verifyFallback(sectionType: RecommendedSectionType, offset: Long, limit: Int) {
Mockito.verify(fallbackService).refreshIfMissing(
eqValue(sectionType),
eqValue(offset),
eqValue(limit),
anyLocalDateTime()
)
}
private fun <T> eqValue(value: T): T {
return Mockito.eq(value) ?: value
}
private fun allowLazyRefreshOnce() {
Mockito.doReturn(lazyRefreshMarker).`when`(redissonClient).getBucket<String>(Mockito.anyString())
Mockito.doReturn(true, false).`when`(lazyRefreshMarker).setIfAbsent(
eqValue("1"),
eqValue(Duration.ofDays(2))
)
}
}